Showing 503 of 577 total issues

File cat-user.css.php has 1225 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a 
 * project that has received funding from the European Union’s Framework 
Severity: Major
Found in web/skins/modern/resources/css/cat-user.css.php - About 3 days to fix

    Method listDevices has 504 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function listDevices($profile = 0, $orAlways = 0) {
            \core\common\Entity::intoThePotatoes();
            $lang = new \core\common\Language();
    /*      Uncomment lines below if you have button images and want to use them
     * 
    Severity: Major
    Found in devices/Devices-template.php - About 2 days to fix

      File main.py has 925 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      #!/usr/bin/env python3
      """
       * **************************************************************************
       * Contributions to this work were made on behalf of the GÉANT project,
       * a project that has received funding from the European Union’s Framework
      Severity: Major
      Found in devices/linux/Files/main.py - About 2 days to fix

        File cat.css.php has 855 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /*
         * *****************************************************************************
         * Contributions to this work were made on behalf of the GÉANT project, a 
         * project that has received funding from the European Union’s Framework 
        Severity: Major
        Found in web/resources/css/cat.css.php - About 2 days to fix

          File cat_js.php has 853 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          /*
           * *****************************************************************************
           * Contributions to this work were made on behalf of the GÉANT project, a 
           * project that has received funding from the European Union’s Framework 
          Severity: Major
          Found in web/skins/modern/user/js/cat_js.php - About 2 days to fix

            File action_realmcheck.php has 845 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            /*
             * *****************************************************************************
             * Contributions to this work were made on behalf of the GÉANT project, a 
             * project that has received funding from the European Union’s Framework 
            Severity: Major
            Found in web/diag/action_realmcheck.php - About 2 days to fix

              File RADIUSTests.php has 805 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              
              /*
               * *****************************************************************************
               * Contributions to this work were made on behalf of the GÉANT project, a 
              Severity: Major
              Found in core/diag/RADIUSTests.php - About 1 day to fix

                File diag.php has 798 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                /*
                 * *****************************************************************************
                 * Contributions to this work were made on behalf of the GÉANT project, a 
                 * project that has received funding from the European Union’s Framework 
                Severity: Major
                Found in web/skins/modern/diag/diag.php - About 1 day to fix

                  Function collectClients has a Cognitive Complexity of 90 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function collectClients()
                      {
                          $clientstest = [];
                          foreach ($this->allReachabilityResults['clients'] as $clients) {
                              $hostindex = $clients->hostindex; 
                  Severity: Minor
                  Found in core/diag/RADIUSTestsUI.php - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function listDevices has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function listDevices()
                      {
                          $returnarray = [];
                          $redirect = $this->getAttributes("device-specific:redirect"); // this might return per-device ones or the general one
                          // if it was a general one, we are done. Find out if there is one such
                  Severity: Minor
                  Found in core/AbstractProfile.php - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File SanityTests.php has 654 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  /*
                   * *****************************************************************************
                   * Contributions to this work were made on behalf of the GÉANT project, a 
                  Severity: Major
                  Found in core/SanityTests.php - About 1 day to fix

                    File edit_silverbullet.php has 641 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    /*
                     * Contributions to this work were made on behalf of the GÉANT project, a 
                     * project that has received funding from the European Union’s Horizon 2020 
                     * research and innovation programme under Grant Agreement No. 731122 (GN4-2).
                    Severity: Major
                    Found in web/admin/edit_silverbullet.php - About 1 day to fix

                      Method __construct has 277 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function __construct()
                          {
                              parent::__construct();
                              common\Entity::intoThePotatoes();
                      
                      
                      Severity: Major
                      Found in core/CAT.php - About 1 day to fix

                        File overview_org.php has 620 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        /*
                         * *****************************************************************************
                         * Contributions to this work were made on behalf of the GÉANT project, a 
                         * project that has received funding from the European Union’s Framework 
                        Severity: Major
                        Found in web/admin/overview_org.php - About 1 day to fix

                          Method displayDeploymentPropertyWidget has 242 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function displayDeploymentPropertyWidget(&$deploymentObject) {
                              // RADIUS status icons
                              $radiusMessages = [
                                  \core\AbstractDeployment::RADIUS_OK => ['icon' => '../resources/images/icons/Quetto/check-icon.png', 'text' => _("Successfully set profile")],
                                  \core\AbstractDeployment::RADIUS_FAILURE => ['icon' => '../resources/images/icons/Quetto/no-icon.png', 'text' => _("Some problem occurred during profile update")],
                          Severity: Major
                          Found in web/admin/overview_org.php - About 1 day to fix

                            Method htmlHeadCode has 222 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function htmlHeadCode() {
                                    $cat = new \core\CAT();
                                    \core\common\Entity::intoThePotatoes();
                                    $retval = "<script type='text/javascript' src='https://maps.googleapis.com/maps/api/js?key=" . \config\Master::APPEARANCE['google_maps_api_key'] . "'></script>
                                <script type='text/javascript'>
                            Severity: Major
                            Found in web/lib/admin/MapGoogle.php - About 1 day to fix

                              File MobileconfigSuperclass.php has 530 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              <?php
                              
                              /*
                               * *****************************************************************************
                               * Contributions to this work were made on behalf of the GÉANT project, a 
                              Severity: Major
                              Found in devices/apple_mobileconfig/MobileconfigSuperclass.php - About 1 day to fix

                                Function displayDeploymentPropertyWidget has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
                                Open

                                function displayDeploymentPropertyWidget(&$deploymentObject) {
                                    // RADIUS status icons
                                    $radiusMessages = [
                                        \core\AbstractDeployment::RADIUS_OK => ['icon' => '../resources/images/icons/Quetto/check-icon.png', 'text' => _("Successfully set profile")],
                                        \core\AbstractDeployment::RADIUS_FAILURE => ['icon' => '../resources/images/icons/Quetto/no-icon.png', 'text' => _("Some problem occurred during profile update")],
                                Severity: Minor
                                Found in web/admin/overview_org.php - About 1 day to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                File Devices-template.php has 520 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                <?php
                                
                                /*
                                 * *****************************************************************************
                                 * Contributions to this work were made on behalf of the GÉANT project, a 
                                Severity: Major
                                Found in devices/Devices-template.php - About 1 day to fix

                                  Function prepareEapConfig has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      private function prepareEapConfig($attr)
                                      {
                                          $outerUser = '';
                                          $vistaExt = '';
                                          $w7Ext = '';
                                  Severity: Minor
                                  Found in devices/ms/DeviceVista7.php - About 1 day to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language