Sign upLogin

Gapminder/vizabi

View on GitHub
Star
src/base/reader.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function read has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  read(query, parsers = {}) {
    const originalQuery = query;
    query = this._normalizeQuery(query, parsers);

    const {
Severity: Minor
Found in src/base/reader.js - About 1 hr to fix

    Function _normalizeQuery has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      _normalizeQuery(_query, parsers) {
    const query = Object.assign({}, _query);
    const { where = {}, join = {} } = query;

    if (where.$and) {
    Severity: Minor
    Found in src/base/reader.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _normalizeQuery has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _normalizeQuery(_query, parsers) {
    const query = Object.assign({}, _query);
    const { where = {}, join = {} } = query;

    if (where.$and) {
    Severity: Minor
    Found in src/base/reader.js - About 1 hr to fix

      Function _testCondition has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        _testCondition(condition, conditionKey, row) {
    const logicalTest = this.LOGICAL_TEST[conditionKey];
    const rowValue = logicalTest ? conditionKey : row[conditionKey];

    // if the column is missing, then don't apply filter
      Severity: Minor
      Found in src/base/reader.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _applyQuery has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _applyQuery(query) {
    const {
      select,
      from
    } = query;
      Severity: Minor
      Found in src/base/reader.js - About 1 hr to fix

        Function error has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          error(code, message, payload, query, file) {
        Severity: Minor
        Found in src/base/reader.js - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status