Sign upLogin

Gapminder/vizabi

View on GitHub
Star
src/components/dialogs/_dialog.js

Summary

Maintainability
D
2 days
Test Coverage

Function resize has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

  resize() {
    if (this.placeholderEl && this.rootEl && this.placeholderEl.classed("vzb-top-dialog")) {
      this.placeholderEl.classed("notransition", true);

      const profile = this.getLayoutProfile();
Severity: Minor
Found in src/components/dialogs/_dialog.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dialogDrag has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

function dialogDrag(element, container, xOffset) {
  let posX, posY, divTop, divRight, marginRight, marginLeft, xOffsetRight, xOffsetLeft, eWi, eHe, cWi, cHe, diffX, diffY;

  return {
    move(x, y) {
Severity: Minor
Found in src/components/dialogs/_dialog.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dialogDrag has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function dialogDrag(element, container, xOffset) {
  let posX, posY, divTop, divRight, marginRight, marginLeft, xOffsetRight, xOffsetLeft, eWi, eHe, cWi, cHe, diffX, diffY;

  return {
    move(x, y) {
Severity: Minor
Found in src/components/dialogs/_dialog.js - About 1 hr to fix

    Function resize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      resize() {
    if (this.placeholderEl && this.rootEl && this.placeholderEl.classed("vzb-top-dialog")) {
      this.placeholderEl.classed("notransition", true);

      const profile = this.getLayoutProfile();
    Severity: Minor
    Found in src/components/dialogs/_dialog.js - About 1 hr to fix

      Function ready has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ready() {
    const _this = this;
    this.placeholderEl = d3.select(this.placeholder);
    this.rootEl = this.root.element instanceof Array ? this.root.element : d3.select(this.root.element);
    this.dragHandler = this.placeholderEl.select("[data-click='dragDialog']");
      Severity: Minor
      Found in src/components/dialogs/_dialog.js - About 1 hr to fix

        Function _setMaxHeight has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          _setMaxHeight() {
    let totalHeight = this.root.element.offsetHeight;
    if (this.getLayoutProfile() !== "small") {
      if (!this.topPos && (this.getLayoutProfile() === "large" && this.rootEl.classed("vzb-dialog-expand-true"))) {
        const dialogBottom = parseInt(this.placeholderEl.style("bottom"), 10);
        Severity: Minor
        Found in src/components/dialogs/_dialog.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                    if (this.isOpen) this.placeholderEl.style("right", this.rightPos);
        Severity: Major
        Found in src/components/dialogs/_dialog.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      if (this.isOpen) this.placeholderEl.style("top", this.topPos);
          Severity: Major
          Found in src/components/dialogs/_dialog.js - About 45 mins to fix

            Consider simplifying this complex logical expression.
            Open

                  if (profile !== "small") {
        const chartWidth = parseInt(this.rootEl.style("width"), 10) || 0;
        const chartHeight = parseInt(this.rootEl.style("height"), 10) || 0;
        const dialogWidth = parseInt(this.placeholderEl.style("width"), 10) || 0;
        const dialogHeight = parseInt(this.placeholderEl.style("height"), 10) || 0;
            Severity: Major
            Found in src/components/dialogs/_dialog.js - About 40 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (!utils.isTouchDevice()) {
        posX = evt.sourceEvent.clientX;
        posY = evt.sourceEvent.clientY;
      } else {
        const touchCoord = d3.touches(container.node());
              Severity: Major
              Found in src/components/dialogs/_dialog.js and 1 other location - About 3 hrs to fix
              src/components/dialogs/_dialog.js on lines 304..311

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 102.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (!utils.isTouchDevice()) {
        posX = evt.sourceEvent.clientX;
        posY = evt.sourceEvent.clientY;
      } else {
        const touchCoord = d3.touches(container.node());
              Severity: Major
              Found in src/components/dialogs/_dialog.js and 1 other location - About 3 hrs to fix
              src/components/dialogs/_dialog.js on lines 281..288

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 102.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  this.rootEl = this.root.element instanceof Array ? this.root.element : d3.select(this.root.element);
              Severity: Minor
              Found in src/components/dialogs/_dialog.js and 1 other location - About 50 mins to fix
              src/components/dialogs/dialogs.js on lines 58..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status