Sign upLogin

Gapminder/vizabi

View on GitHub
Star
src/components/indicatorpicker/indicatorpicker.js

Summary

Maintainability
C
1 day
Test Coverage

Function init has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  init(config, context) {

    this.name = "gapminder-indicatorpicker";
    this.template = '<span class="vzb-ip-holder"><span class="vzb-ip-select"></span><span class="vzb-ip-info"></span></span>';
Severity: Major
Found in src/components/indicatorpicker/indicatorpicker.js - About 2 hrs to fix

    Function updateView has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      updateView() {
    if (!this._readyOnce) return;

    const _this = this;
    const translator = this.model.locale.getTFunction();
    Severity: Minor
    Found in src/components/indicatorpicker/indicatorpicker.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function readyOnce has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      readyOnce() {
    const _this = this;

    this.el_select = d3.select(this.element).select(".vzb-ip-select");
    Severity: Minor
    Found in src/components/indicatorpicker/indicatorpicker.js - About 1 hr to fix

      Function init has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        init(config, context) {

    this.name = "gapminder-indicatorpicker";
    this.template = '<span class="vzb-ip-holder"><span class="vzb-ip-select"></span><span class="vzb-ip-info"></span></span>';
      Severity: Minor
      Found in src/components/indicatorpicker/indicatorpicker.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateView has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        updateView() {
    if (!this._readyOnce) return;

    const _this = this;
    const translator = this.model.locale.getTFunction();
      Severity: Minor
      Found in src/components/indicatorpicker/indicatorpicker.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                        if (clModel.label.getItems()[value]) value = clModel.label.getItems()[value];
        Severity: Major
        Found in src/components/indicatorpicker/indicatorpicker.js - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status