Gapminder/vizabi

View on GitHub
src/components/zoombuttonlist/zoombuttonlist.js

Summary

Maintainability
F
3 days
Test Coverage

Function init has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  init(config, context) {

    //set properties
    const _this = this;
    this.name = "gapminder-zoombuttonlist";
Severity: Major
Found in src/components/zoombuttonlist/zoombuttonlist.js - About 2 hrs to fix

    Function _addButtons has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _addButtons(button_list, button_expand) {
        const _this = this;
        this._components_config = [];
        const details_btns = [];
        if (!button_list.length) return;
    Severity: Minor
    Found in src/components/zoombuttonlist/zoombuttonlist.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        proceedClick(id) {
          const _this = this;
          const btn = _this.element.selectAll(".vzb-buttonlist-btn[data-btn='" + id + "']");
          const classes = btn.attr("class");
          const btn_config = _this._available_buttons[id];
      Severity: Major
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 1 other location - About 7 hrs to fix
      src/components/buttonlist/buttonlist.js on lines 260..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 178.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          this.element.selectAll("button").data(details_btns)
            .enter().append("button")
            .attr("class", d => {
              let cls = "vzb-buttonlist-btn";
              if (button_expand.length > 0) {
      Severity: Major
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 1 other location - About 6 hrs to fix
      src/components/buttonlist/buttonlist.js on lines 426..441

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 167.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          buttons.on("click", function() {
      
            d3.event.preventDefault();
            d3.event.stopPropagation();
      
      
      Severity: Major
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 1 other location - About 2 hrs to fix
      src/components/buttonlist/buttonlist.js on lines 446..453

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            "plus": {
              title: "buttons/cursorplus",
              icon: "cursorPlus",
              func: this.toggleCursorMode.bind(this),
              required: true,
      Severity: Major
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 8 other locations - About 1 hr to fix
      src/components/buttonlist/buttonlist.js on lines 86..93
      src/components/buttonlist/buttonlist.js on lines 94..101
      src/components/buttonlist/buttonlist.js on lines 102..109
      src/components/buttonlist/buttonlist.js on lines 110..117
      src/components/buttonlist/buttonlist.js on lines 118..125
      src/components/zoombuttonlist/zoombuttonlist.js on lines 43..50
      src/components/zoombuttonlist/zoombuttonlist.js on lines 59..66
      src/components/zoombuttonlist/zoombuttonlist.js on lines 67..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            "arrow": {
              title: "buttons/cursorarrow",
              icon: "cursorArrow",
              func: this.toggleCursorMode.bind(this),
              required: true,
      Severity: Major
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 8 other locations - About 1 hr to fix
      src/components/buttonlist/buttonlist.js on lines 86..93
      src/components/buttonlist/buttonlist.js on lines 94..101
      src/components/buttonlist/buttonlist.js on lines 102..109
      src/components/buttonlist/buttonlist.js on lines 110..117
      src/components/buttonlist/buttonlist.js on lines 118..125
      src/components/zoombuttonlist/zoombuttonlist.js on lines 51..58
      src/components/zoombuttonlist/zoombuttonlist.js on lines 59..66
      src/components/zoombuttonlist/zoombuttonlist.js on lines 67..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            "minus": {
              title: "buttons/cursorminus",
              icon: "cursorMinus",
              func: this.toggleCursorMode.bind(this),
              required: true,
      Severity: Major
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 8 other locations - About 1 hr to fix
      src/components/buttonlist/buttonlist.js on lines 86..93
      src/components/buttonlist/buttonlist.js on lines 94..101
      src/components/buttonlist/buttonlist.js on lines 102..109
      src/components/buttonlist/buttonlist.js on lines 110..117
      src/components/buttonlist/buttonlist.js on lines 118..125
      src/components/zoombuttonlist/zoombuttonlist.js on lines 43..50
      src/components/zoombuttonlist/zoombuttonlist.js on lines 51..58
      src/components/zoombuttonlist/zoombuttonlist.js on lines 67..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

            "hand": {
              title: "buttons/cursorhand",
              icon: "cursorHand",
              func: this.toggleCursorMode.bind(this),
              required: true,
      Severity: Major
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 8 other locations - About 1 hr to fix
      src/components/buttonlist/buttonlist.js on lines 86..93
      src/components/buttonlist/buttonlist.js on lines 94..101
      src/components/buttonlist/buttonlist.js on lines 102..109
      src/components/buttonlist/buttonlist.js on lines 110..117
      src/components/buttonlist/buttonlist.js on lines 118..125
      src/components/zoombuttonlist/zoombuttonlist.js on lines 43..50
      src/components/zoombuttonlist/zoombuttonlist.js on lines 51..58
      src/components/zoombuttonlist/zoombuttonlist.js on lines 59..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        setButtonActive(id, boolActive) {
          const btn = this.element.selectAll(".vzb-buttonlist-btn[data-btn='" + id + "']");
      
          btn.classed(class_active, boolActive);
        },
      Severity: Minor
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 1 other location - About 40 mins to fix
      src/components/buttonlist/buttonlist.js on lines 489..493

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          this.model_expects = [{
            name: "state",
            type: "model"
          }, {
            name: "ui",
      Severity: Minor
      Found in src/components/zoombuttonlist/zoombuttonlist.js and 2 other locations - About 40 mins to fix
      src/components/dialogs/dialogs.js on lines 27..36
      src/components/minmaxinputs/minmaxinputs.js on lines 26..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status