Sign upLogin

Gapminder/vizabi

View on GitHub
Star
src/models/color.js

Summary

Maintainability
D
2 days
Test Coverage

Function setColor has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  setColor(value, pointer, oldPointer, persistent, force = false) {
    if (value) value = d3.color(value).hex();

    let range;
    const paletteObj = value && pointer ? { [pointer]: value } : {};
Severity: Minor
Found in src/models/color.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _buildColorScale has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  _buildColorScale(scaleType, paletteObject) {
    const _this = this;
    let domain = Object.keys(paletteObject);
    let range = utils.values(paletteObject);
    let scale;
Severity: Minor
Found in src/models/color.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _buildColorScale has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _buildColorScale(scaleType, paletteObject) {
    const _this = this;
    let domain = Object.keys(paletteObject);
    let range = utils.values(paletteObject);
    let scale;
Severity: Major
Found in src/models/color.js - About 2 hrs to fix

    File color.js has 268 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as utils from "base/utils";
import Hook from "models/hook";

/*!
 * VIZABI Color Model (hook)
    Severity: Minor
    Found in src/models/color.js - About 2 hrs to fix

      Function setColor has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        setColor(value, pointer, oldPointer, persistent, force = false) {
    if (value) value = d3.color(value).hex();

    let range;
    const paletteObj = value && pointer ? { [pointer]: value } : {};
      Severity: Minor
      Found in src/models/color.js - About 1 hr to fix

        Function getDefaultPalette has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          getDefaultPalette() {
    const conceptpropsColor = this.getConceptprops().color;
    let palette;

    this.discreteDefaultPalette = false;
        Severity: Minor
        Found in src/models/color.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setColor has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          setColor(value, pointer, oldPointer, persistent, force = false) {
        Severity: Minor
        Found in src/models/color.js - About 35 mins to fix

          Function getColorShade has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            getColorShade(args) {
    const palette = this.getPalette();

    if (!args) return utils.warn("getColorShade() is missing arguments");
          Severity: Minor
          Found in src/models/color.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                const limits = timeMdl.splash ?
        { min: timeMdl.parse(timeMdl.startOrigin), max: timeMdl.parse(timeMdl.endOrigin) }
        :
        { min: timeMdl.start, max: timeMdl.end };
          Severity: Major
          Found in src/models/color.js and 1 other location - About 1 hr to fix
          src/models/axis.js on lines 69..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status