Sign upLogin

Gapminder/vizabi

View on GitHub
Star
src/models/hook.js

Summary

Maintainability
F
3 days
Test Coverage

File hook.js has 422 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as utils from "base/utils";
import DataConnected from "models/dataconnected";
import EventSource from "base/events";

/*!
Severity: Minor
Found in src/models/hook.js - About 6 hrs to fix

    Hook has 40 functions (exceeds 20 allowed). Consider refactoring.
    Open

    const Hook = DataConnected.extend({

  //some hooks can be important. like axis x and y
  //that means, if X or Y doesn't have data at some point, we can't show markers
  _important: false,
    Severity: Minor
    Found in src/models/hook.js - About 5 hrs to fix

      Function getQuery has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

        getQuery(splashScreen) {
    let filters;

    //error if there's nothing to hook to
    if (Object.keys(this._space).length < 1) {
      Severity: Minor
      Found in src/models/hook.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getQuery has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getQuery(splashScreen) {
    let filters;

    //error if there's nothing to hook to
    if (Object.keys(this._space).length < 1) {
      Severity: Major
      Found in src/models/hook.js - About 2 hrs to fix

        Function getTickFormatter has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          getTickFormatter(_removePrefix) {

    const _this = this;
    const SHARE = "share";
    const PERCENT = "percent";
        Severity: Minor
        Found in src/models/hook.js - About 1 hr to fix

          Function getLimitsByDimensions has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

            getLimitsByDimensions(dims) {
    const filtered = this.dataSource.getData(this._dataId, "nested", dims);
    const values = {};
    const limitsDim = {};
    const attr = this.which;
          Severity: Minor
          Found in src/models/hook.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getLimitsByDimensions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            getLimitsByDimensions(dims) {
    const filtered = this.dataSource.getData(this._dataId, "nested", dims);
    const values = {};
    const limitsDim = {};
    const attr = this.which;
          Severity: Minor
          Found in src/models/hook.js - About 1 hr to fix

            Function setWhich has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              setWhich(newValue) {

    const obj = { which: newValue.concept };

    if (newValue.dataSource) obj.data = newValue.dataSource;
            Severity: Minor
            Found in src/models/hook.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function autoconfigureModel has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              autoconfigureModel(autoconfigResult) {

    if (!this.which && this.autoconfig) {
      if (!autoconfigResult) autoconfigResult = this._parent.getAvailableConcept(this.autoconfig);
            Severity: Minor
            Found in src/models/hook.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              validate() {
    this._super();

    // validate scale type: only makes sense if which is defined
    if (this.which) {
            Severity: Minor
            Found in src/models/hook.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                  return (formatted + prefix + (percentageMode === PERCENT || percentageMode === SHARE ? "%" : ""));
            Severity: Major
            Found in src/models/hook.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    const filtered = items.reduce((filtered, d) => {

        // check for dates
        const f = (utils.isDate(d[attr])) ? d[attr] : parseFloat(d[attr]);
              Severity: Major
              Found in src/models/hook.js and 1 other location - About 3 hrs to fix
              src/base/datastorage.js on lines 328..340

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                handleDataConnectedChange(evt) {
    //defer is necessary because other events might be queued.
    //load right after such events
    utils.defer(() => {
      this.startLoading()
              Severity: Minor
              Found in src/models/hook.js and 1 other location - About 45 mins to fix
              src/models/entities.js on lines 81..88

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status