GemsTracker/gemstracker-library

View on GitHub

Showing 1,617 of 4,272 total issues

Function getProfile has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    public function getProfile()
    {
        $queries = '';
        foreach ($this->_db as $name => $adapter) {
            if ($profiles = $adapter->getProfiler()->getQueryProfiles()) {
Severity: Minor
Found in classes/ZFDebug/Controller/Plugin/Debug/Plugin/Database.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function runScript has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    public function runScript(array $data, $includeResultSets = false)
    {
        $results = array();
        if ($data['script']) {
            $queries = \MUtil_Parser_Sql_WordsParser::splitStatements($data['script'], false);
Severity: Minor
Found in classes/Gems/Model/DbaModel.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File SurveyMaintenanceModel.php has 399 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems
Severity: Minor
Found in classes/Gems/Model/SurveyMaintenanceModel.php - About 5 hrs to fix

    Method getHtmlOutput has 139 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getHtmlOutput(\Zend_View_Abstract $view)
        {
            $this->_initView($view);
    
            $main = $this->creator->div(array('class' => 'panel panel-default', 'id' => 'trackwrapper', 'renderClosingTag' => true));
    Severity: Major
    Found in classes/Gems/Snippets/Respondent/TrafficLightTokenSnippet.php - About 5 hrs to fix

      File RespondentExport.php has 397 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      /**
       *
       * @package    Gems
      Severity: Minor
      Found in classes/Gems/Export/RespondentExport.php - About 5 hrs to fix

        File StaffModel.php has 395 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        /**
         * The staff model
         *
        Severity: Minor
        Found in classes/Gems/Model/StaffModel.php - About 5 hrs to fix

          Method _getTracks has 137 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function _getTracks($trackType, $pageRef, $trackTypeDescription)
              {
                  switch ($trackType) {
                      case 'tracks':
                          $action = 'create';
          Severity: Major
          Found in classes/Gems/Snippets/Tracker/AddTracksSnippet.php - About 5 hrs to fix

            File UserLoader.php has 393 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            /**
             *
             * @package    Gems
            Severity: Minor
            Found in classes/Gems/User/UserLoader.php - About 5 hrs to fix

              Method getModel has 134 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getModel()
                  {
                      if (empty($this->model)) {
                          try {
                              $model = new \Gems_Model_JoinModel($this->getFormID(), $this->getTableName(), 'orf');
              Severity: Major
              Found in classes/OpenRosa/Tracker/Source/Form.php - About 5 hrs to fix

                Gems_Agenda_Appointment has 40 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Gems_Agenda_Appointment extends \MUtil_Translate_TranslateableAbstract
                {
                    /**
                     *
                     * @var int The id of the appointment
                Severity: Minor
                Found in classes/Gems/Agenda/Appointment.php - About 5 hrs to fix

                  Gems_User_Organization has 40 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Gems_User_Organization extends \Gems_Registry_CachedArrayTargetAbstract
                  {
                      /**
                       *
                       * @var array of class name => class label
                  Severity: Minor
                  Found in classes/Gems/User/Organization.php - About 5 hrs to fix

                    Function getSurveysForExport has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getSurveysForExport($trackId = null, $roundDescription = null, $flat = false, $keepSourceInactive = false)
                        {
                            // Read some data from tables, initialize defaults...
                            $select = $this->db->select();
                    
                    
                    Severity: Minor
                    Found in classes/Gems/Util/DbLookup.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function toActionLink has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function toActionLink($parameterOrLabelSources_args = null)
                        {
                            if (!$this->get('allowed')) {
                                return null;
                            }
                    Severity: Minor
                    Found in classes/Gems/Menu/SubMenuItem.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function submissionAction has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function submissionAction()
                        {
                            $this->makeRosaResponse();
                    
                            if ($this->getRequest()->isHead()) {
                    Severity: Minor
                    Found in classes/Gems/Default/OpenrosaAction.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File DateSelectorAbstract.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    
                    /**
                     *
                     * @package    Gems
                    Severity: Minor
                    Found in classes/Gems/Selector/DateSelectorAbstract.php - About 5 hrs to fix

                      Gems_Tracker_Respondent has 39 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class Gems_Tracker_Respondent extends \Gems_Registry_TargetAbstract
                      {
                          use \Gems\Translate\GenderTranslation;
                      
                          /**
                      Severity: Minor
                      Found in classes/Gems/Tracker/Respondent.php - About 5 hrs to fix

                        Gems_Menu has 39 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class Gems_Menu extends \Gems_Menu_MenuAbstract implements \MUtil_Html_HtmlInterface
                        {
                            /**
                             *
                             * @var \Gems_Menu_SubMenuItem
                        Severity: Minor
                        Found in classes/Gems/Menu.php - About 5 hrs to fix

                          Method getChanges has 128 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function getChanges(array $context, $new)
                              {
                                  // Only change anything when there are filters
                                  $filters = $this->loader->getAgenda()->getFilterList();
                          

                            Function _recurseForm has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                            Open

                                protected function _recurseForm(\Zend_Form $form)
                             {
                                    $subFormsWithErrors = array();
                                    $subFormMessages = array();
                                    $tabId = 0;
                            Severity: Minor
                            Found in classes/Gems/Form/Decorator/TabErrors.php - About 5 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function execute has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
                                {
                                    $this->currentUser->disableMask();
                            
                                    $sql = $this->db->select()->from('gems__comm_jobs')
                            Severity: Minor
                            Found in classes/Gems/Task/Mail/ExecuteMailJobTask.php - About 5 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language