GeoKnow/Jassa-Core

View on GitHub
trash/to-port/facete/QueryUtils.js

Summary

Maintainability
D
1 day
Test Coverage

Function createQueryCount has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

        createQueryCount: function(elements, limit, variable, outputVar, groupVars, useDistinct, options) {

            var exprVar = variable ? new sparql.ExprVar(variable) : null;

            
Severity: Minor
Found in trash/to-port/facete/QueryUtils.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createQueryCountDoesNotWorkWithVirtuoso has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        createQueryCountDoesNotWorkWithVirtuoso: function(elements, limit, variable, outputVar, groupVars, useDistinct, options) {
    
            
            var exprVar = variable ? new sparql.ExprVar(variable) : null;
            
Severity: Minor
Found in trash/to-port/facete/QueryUtils.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createQueryCount has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        createQueryCount: function(elements, limit, variable, outputVar, groupVars, useDistinct, options) {

            var exprVar = variable ? new sparql.ExprVar(variable) : null;

            
Severity: Minor
Found in trash/to-port/facete/QueryUtils.js - About 1 hr to fix

    Function createQueryCountDoesNotWorkWithVirtuoso has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            createQueryCountDoesNotWorkWithVirtuoso: function(elements, limit, variable, outputVar, groupVars, useDistinct, options) {
        
                
                var exprVar = variable ? new sparql.ExprVar(variable) : null;
                
    Severity: Minor
    Found in trash/to-port/facete/QueryUtils.js - About 1 hr to fix

      Function createQueryCount has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              createQueryCount: function(elements, limit, variable, outputVar, groupVars, useDistinct, options) {
      Severity: Major
      Found in trash/to-port/facete/QueryUtils.js - About 50 mins to fix

        Function createQueryCountDoesNotWorkWithVirtuoso has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                createQueryCountDoesNotWorkWithVirtuoso: function(elements, limit, variable, outputVar, groupVars, useDistinct, options) {
        Severity: Major
        Found in trash/to-port/facete/QueryUtils.js - About 50 mins to fix

          Function createQueryFacetCount has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  createQueryFacetCount: function(concept, facetVar, countFacetVar, isInverse, sampleSize) {
          Severity: Minor
          Found in trash/to-port/facete/QueryUtils.js - About 35 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if(groupVars) {
                            _(groupVars).each(function(groupVar) {
                                result.getProject().add(groupVar);
                                result.getGroupBy().push(new sparql.ExprVar(groupVar));
                            });
            Severity: Major
            Found in trash/to-port/facete/QueryUtils.js and 1 other location - About 1 hr to fix
            trash/to-port/facete/QueryUtils.js on lines 259..264

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if(groupVars) {
                            _(groupVars).each(function(groupVar) {
                                result.getProject().add(groupVar);
                                result.getGroupBy().push(new sparql.ExprVar(groupVar));
                            });
            Severity: Major
            Found in trash/to-port/facete/QueryUtils.js and 1 other location - About 1 hr to fix
            trash/to-port/facete/QueryUtils.js on lines 154..159

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if(groupVars) {
                                for(var i = 0; i < groupVars.length; ++i) {                 
                                    var groupVar = groupVars[i];                    
                                    subQuery.getProject().add(groupVar);
                                    //subQuery.groupBy.push(groupVar);
            Severity: Major
            Found in trash/to-port/facete/QueryUtils.js and 1 other location - About 1 hr to fix
            lib/sparql/QueryUtils.js on lines 64..70

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status