Sign upLogin

Georgynet/Blog-Yii2

View on GitHub
Star

Showing 3 of 25 total issues

Method up has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function up()
    {
        $tableOptions = null;
        if ($this->db->driverName === 'mysql') {
            $tableOptions = 'CHARACTER SET utf8 COLLATE utf8_general_ci ENGINE=InnoDB';
Severity: Minor
Found in console/migrations/m141018_161427_18102014.php - About 1 hr to fix

    Function actionSignup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionSignup()
    {
        $model = new SignupForm();
        if ($model->load(Yii::$app->request->post())) {
            if ($user = $model->signup()) {
    Severity: Minor
    Found in frontend/controllers/SiteController.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function init()
    {
        parent::init();

        $session = \Yii::$app->getSession();
    Severity: Minor
    Found in frontend/widgets/Alert.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language