Sign upLogin

Geovation/photos

View on GitHub
Star
functions/index.js

Summary

Maintainability
D
1 day
Test Coverage

File index.js has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const _ = require("lodash");
const json2csv = require("json2csv");
// https://firebase.google.com/docs/functions/locations
const functions = require("firebase-functions").region("europe-west2");
const mkdirp = require("mkdirp");
Severity: Minor
Found in functions/index.js - About 4 hrs to fix

    Function generateThumbnail has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      .onFinalize(async (object) => {
    // File and directory paths.
    const filePath = object.name;
    const contentType = object.contentType; // This is the image MIME type
    const fileDir = path.dirname(filePath);
    Severity: Minor
    Found in functions/index.js - About 2 hrs to fix

      Function hostMetadata has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function hostMetadata(req, res) {
  const BUCKET = config.FIREBASE.config.storageBucket;
  const SERVER_URL = config.metadata.serverUrl;
  const TW_SITE = config.metadata.twSite;
  const TW_CREATOR = config.metadata.twCreator;
      Severity: Minor
      Found in functions/index.js - About 1 hr to fix

        Function updateStats has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          .onPublish(async (message, context) => {
    const stats = {
      totalUploaded: 0,
      moderated: 0,
      published: 0,
        Severity: Minor
        Found in functions/index.js - About 1 hr to fix

          Function hostMetadata has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          async function hostMetadata(req, res) {
  const BUCKET = config.FIREBASE.config.storageBucket;
  const SERVER_URL = config.metadata.serverUrl;
  const TW_SITE = config.metadata.twSite;
  const TW_CREATOR = config.metadata.twCreator;
          Severity: Minor
          Found in functions/index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          function convertFirebaseTimestampFieldsIntoDate(photo) {
  const newPhoto = _.cloneDeep(photo);
  _.forEach(newPhoto, (value, field) => {
    if (value.toDate) {
      newPhoto[field] = value.toDate();
          Severity: Major
          Found in functions/index.js and 1 other location - About 2 hrs to fix
          src/features/firebase/dbFirebase.js on lines 133..141

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const uploadMain = bucket
      .upload(tempLocalMainFile, {
        destination: mainFilePath,
        metadata: metadata,
      })
          Severity: Minor
          Found in functions/index.js and 1 other location - About 40 mins to fix
          functions/index.js on lines 144..149

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const uploadThumb = bucket
      .upload(tempLocalThumbFile, {
        destination: thumbFilePath,
        metadata: metadata,
      })
          Severity: Minor
          Found in functions/index.js and 1 other location - About 40 mins to fix
          functions/index.js on lines 150..155

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status