Geovation/photos

View on GitHub
src/features/firebase/authFirebase.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function onAuthStateChanged has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const onAuthStateChanged = (fn) => {
  onUserChangeCallBackFn = fn;
  const firebaseStatusChange = (user) => {
    currentUser = user;
    if (config.USER.ENABLE_GRAVATAR_PROFILES && currentUser) {
Severity: Minor
Found in src/features/firebase/authFirebase.js - About 1 hr to fix

    Function firebaseStatusChange has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const firebaseStatusChange = (user) => {
        currentUser = user;
        if (config.USER.ENABLE_GRAVATAR_PROFILES && currentUser) {
          gtagSetId(user.uid);
          gtagEvent("Logged in", "User", user.uid);
    Severity: Minor
    Found in src/features/firebase/authFirebase.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

          if (config.USER.ENABLE_GRAVATAR_PROFILES && currentUser) {
            gtagSetId(user.uid);
            gtagEvent("Logged in", "User", user.uid);
      
            // when the user logs in, need to save his fcm token so that the cloud function can message him is required.
      Severity: Major
      Found in src/features/firebase/authFirebase.js - About 1 hr to fix

        Function onAuthStateChanged has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        const onAuthStateChanged = (fn) => {
          onUserChangeCallBackFn = fn;
          const firebaseStatusChange = (user) => {
            currentUser = user;
            if (config.USER.ENABLE_GRAVATAR_PROFILES && currentUser) {
        Severity: Minor
        Found in src/features/firebase/authFirebase.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status