Sign upLogin

Geovation/photos

View on GitHub
Star
src/features/firebase/dbFirebase.js

Summary

Maintainability
D
2 days
Test Coverage

File dbFirebase.js has 466 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import firebase from "firebase/app";
import _ from "lodash";
 
import * as localforage from "localforage";
Severity: Minor
Found in src/features/firebase/dbFirebase.js - About 7 hrs to fix

    Function uploadPhoto has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function uploadPhoto(data, imgSrc, onProgress) {
  const rtn = {};
  let canceled = false;
  let uploadTask;
  let resolve;
    Severity: Minor
    Found in src/features/firebase/dbFirebase.js - About 1 hr to fix

      Function processScheduledUpload has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function processScheduledUpload(uploadItem) {
  uploadsProgress[uploadItem.id] = { ...uploadItem, progress: 0 };
  const { location, imgSrc, fieldsValues } = uploadItem;

  // upload it
      Severity: Minor
      Found in src/features/firebase/dbFirebase.js - About 1 hr to fix

        Function promise has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          rtn.promise = new Promise(async (res, rej) => {
    resolve = res;
    reject = rej;
    onProgress(0);
    try {
        Severity: Minor
        Found in src/features/firebase/dbFirebase.js - About 1 hr to fix

          Function uploadPhoto has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          function uploadPhoto(data, imgSrc, onProgress) {
  const rtn = {};
  let canceled = false;
  let uploadTask;
  let resolve;
          Severity: Minor
          Found in src/features/firebase/dbFirebase.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function extractPhoto has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function extractPhoto(data, id) {
  // some data from Firebase cannot be stringified into json, so we need to convert it into other format first.
  const photo = _.mapValues(data, (fieldValue, fieldKey, doc) => {
    if (fieldValue instanceof firebase.firestore.DocumentReference) {
      return fieldValue.path;
          Severity: Minor
          Found in src/features/firebase/dbFirebase.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function publishedPhotosRT has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function publishedPhotosRT(addedFn, modifiedFn, removedFn, errorFn, fromDate) {
          Severity: Minor
          Found in src/features/firebase/dbFirebase.js - About 35 mins to fix

            Function photosFromRefRT has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              photosRef,
  onAdd,
  onUpdate,
  onRemove,
  onError = console.error
            Severity: Minor
            Found in src/features/firebase/dbFirebase.js - About 35 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function convertFirebaseTimestampFieldsIntoDate(photo) {
  const newPhoto = _.cloneDeep(photo);
  _.forEach(newPhoto, (value, field) => {
    if (value.toDate) {
      newPhoto[field] = value.toDate();
              Severity: Major
              Found in src/features/firebase/dbFirebase.js and 1 other location - About 2 hrs to fix
              functions/index.js on lines 226..234

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 75.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                photo.moderated =
    photo.moderated instanceof firebase.firestore.Timestamp
      ? photo.moderated.toDate()
      : new Date(photo.moderated);
              Severity: Minor
              Found in src/features/firebase/dbFirebase.js and 1 other location - About 50 mins to fix
              src/features/firebase/dbFirebase.js on lines 31..34

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                photo.updated =
    photo.updated instanceof firebase.firestore.Timestamp
      ? photo.updated.toDate()
      : new Date(photo.updated);
              Severity: Minor
              Found in src/features/firebase/dbFirebase.js and 1 other location - About 50 mins to fix
              src/features/firebase/dbFirebase.js on lines 36..39

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  data.location = new firebase.firestore.GeoPoint(
      Number(data.latitude) || 0,
      Number(data.longitude) || 0
    );
              Severity: Minor
              Found in src/features/firebase/dbFirebase.js and 1 other location - About 40 mins to fix
              src/features/firebase/dbFirebase.js on lines 161..164

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                data.location = new firebase.firestore.GeoPoint(
    Number(data.latitude) || 0,
    Number(data.longitude) || 0
  );
              Severity: Minor
              Found in src/features/firebase/dbFirebase.js and 1 other location - About 40 mins to fix
              src/features/firebase/dbFirebase.js on lines 559..562

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  return {
      type: "Feature",
      geometry: {
        type: "Point",
        coordinates: [photo.location.longitude, photo.location.latitude],
              Severity: Minor
              Found in src/features/firebase/dbFirebase.js and 1 other location - About 35 mins to fix
              src/sagas.js on lines 38..45

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status