Sign upLogin

Gisto/Gisto

View on GitHub
Star
src/reducers/snippets.js

Summary

Maintainability
F
4 days
Test Coverage

Function snippets has 212 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const snippets = (state = initialState, action) => {
  switch (action.type) {
    case AT.GET_SNIPPETS.SUCCESS: {
      const lastUpdated = state.lastUpdated === null ? toISOString() : state.lastUpdated;
Severity: Major
Found in src/reducers/snippets.js - About 1 day to fix

    File snippets.js has 256 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  merge,
  keyBy,
  update,
  set,
    Severity: Minor
    Found in src/reducers/snippets.js - About 2 hrs to fix

      Function snippets has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      export const snippets = (state = initialState, action) => {
  switch (action.type) {
    case AT.GET_SNIPPETS.SUCCESS: {
      const lastUpdated = state.lastUpdated === null ? toISOString() : state.lastUpdated;
      Severity: Minor
      Found in src/reducers/snippets.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], []),
        set(['filter', 'language'], ''),
        set(['filter', 'status'], ''),
      Severity: Major
      Found in src/reducers/snippets.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return flow([
        set(['starred'], without([action.meta.id], state.starred)),
        set(['snippets', action.meta.id, 'star'], false)
      ])(state);
        Severity: Major
        Found in src/reducers/snippets.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return flow([
        set('edit', {}),
        set(['snippets', action.payload.id], snippetStructure(action.payload, state.starred))
      ])(state);
          Severity: Major
          Found in src/reducers/snippets.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return set(
        ['snippets', action.payload.snippetId, 'files', [fileIndex], 'collapsed'],
        !isCollapsed,
        state
      );
            Severity: Major
            Found in src/reducers/snippets.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], []),
        set(['filter', 'language'], action.payload.value),
        set(['filter', 'status'], ''),
              Severity: Major
              Found in src/reducers/snippets.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], []),
        set(['filter', 'language'], ''),
        set(['filter', 'status'], ''),
                Severity: Major
                Found in src/reducers/snippets.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return flow([
        set(['starred'], concat([action.meta.id], state.starred)),
        set(['snippets', action.meta.id, 'star'], true)
      ])(state);
                  Severity: Major
                  Found in src/reducers/snippets.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return set(['comments', action.meta.id], comments, state);
                    Severity: Major
                    Found in src/reducers/snippets.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return set(['filter', 'tags'], without([action.payload.tag], state.filter.tags), state);
                      Severity: Major
                      Found in src/reducers/snippets.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], []),
        set(['filter', 'language'], ''),
        set(['filter', 'status'], action.payload.status),
                        Severity: Major
                        Found in src/reducers/snippets.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return set(['comments', action.meta.id], action.payload, state);
                          Severity: Major
                          Found in src/reducers/snippets.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return set(['edit', 'files', action.payload.uuid, 'delete'], true, state);
                            Severity: Major
                            Found in src/reducers/snippets.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    return set(['comments', action.meta.id], [], state);
                              Severity: Major
                              Found in src/reducers/snippets.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      return set(
        ['snippets', action.payload.id],
        snippetStructure(action.payload, state.starred),
        state
      );
                                Severity: Major
                                Found in src/reducers/snippets.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                        return set('edit', {}, state);
                                  Severity: Major
                                  Found in src/reducers/snippets.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                          return flow([
        set(['edit', 'description'], description),
        set(['edit', 'files'], keyBy('uuid', preparedFiles))
      ])(state);
                                    Severity: Major
                                    Found in src/reducers/snippets.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                            return set(['edit', 'files'], merge(newFile, existingFiles || {}), state);
                                      Severity: Major
                                      Found in src/reducers/snippets.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                              return state;
                                        Severity: Major
                                        Found in src/reducers/snippets.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], []),
        set(['filter', 'language'], ''),
        set(['filter', 'status'], ''),
                                          Severity: Major
                                          Found in src/reducers/snippets.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                  return flow([
        set(['starred'], without([action.meta.id], state.starred)),
        omit([['snippets', action.meta.id]])
      ])(state);
                                            Severity: Major
                                            Found in src/reducers/snippets.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                    return set(updatePath, value, state);
                                              Severity: Major
                                              Found in src/reducers/snippets.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                      return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], tag),
        set(['filter', 'language'], ''),
        set(['filter', 'status'], ''),
                                                Severity: Major
                                                Found in src/reducers/snippets.js - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                        return set(
        ['comments', action.meta.id],
        concat(get(['comments', action.meta.id], state), action.payload),
        state
      );
                                                  Severity: Major
                                                  Found in src/reducers/snippets.js - About 30 mins to fix

                                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                                    Open

                                                        case AT.FILTER_SNIPPETS_BY_UNTAGGED: {
      return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], []),
        set(['filter', 'language'], ''),
                                                    Severity: Major
                                                    Found in src/reducers/snippets.js and 2 other locations - About 1 hr to fix
                                                    src/reducers/snippets.js on lines 123..132
                                                    src/reducers/snippets.js on lines 145..154

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 78.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                                    Open

                                                        case AT.CLEAR_FILTERS: {
      return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], []),
        set(['filter', 'language'], ''),
                                                    Severity: Major
                                                    Found in src/reducers/snippets.js and 2 other locations - About 1 hr to fix
                                                    src/reducers/snippets.js on lines 123..132
                                                    src/reducers/snippets.js on lines 134..143

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 78.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                                    Open

                                                        case AT.FILTER_SNIPPETS_BY_TRUNCATED: {
      return flow([
        set(['filter', 'text'], ''),
        set(['filter', 'tags'], []),
        set(['filter', 'language'], ''),
                                                    Severity: Major
                                                    Found in src/reducers/snippets.js and 2 other locations - About 1 hr to fix
                                                    src/reducers/snippets.js on lines 134..143
                                                    src/reducers/snippets.js on lines 145..154

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 78.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                                    Open

                                                        case AT.SET_STAR.SUCCESS: {
      return flow([
        set(['starred'], concat([action.meta.id], state.starred)),
        set(['snippets', action.meta.id, 'star'], true)
      ])(state);
                                                    Severity: Major
                                                    Found in src/reducers/snippets.js and 1 other location - About 1 hr to fix
                                                    src/reducers/snippets.js on lines 163..168

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 72.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                                    Open

                                                        case AT.UNSET_STAR.SUCCESS: {
      return flow([
        set(['starred'], without([action.meta.id], state.starred)),
        set(['snippets', action.meta.id, 'star'], false)
      ])(state);
                                                    Severity: Major
                                                    Found in src/reducers/snippets.js and 1 other location - About 1 hr to fix
                                                    src/reducers/snippets.js on lines 156..161

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 72.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    There are no issues that match your filters.

                                                    Category
                                                    Status