Sign upLogin

GladysProject/Gladys

View on GitHub
Star
front/src/actions/house.js

Summary

Maintainability
F
3 days
Test Coverage

Function createActions has 293 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createActions(store) {
  const actions = {
    async getHouses(state) {
      store.setState({
        housesGetStatus: RequestStatus.Getting
Severity: Major
Found in front/src/actions/house.js - About 1 day to fix

    Function createActions has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    function createActions(store) {
  const actions = {
    async getHouses(state) {
      store.setState({
        housesGetStatus: RequestStatus.Getting
    Severity: Minor
    Found in front/src/actions/house.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function saveHouse has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async saveHouse(state, houseIndex) {
      store.setState({
        houseUpdateStatus: RequestStatus.Getting
      });
      const house = state.houses[houseIndex];
    Severity: Major
    Found in front/src/actions/house.js - About 3 hrs to fix

      File house.js has 307 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import { RequestStatus } from '../utils/consts';
import update, { extend } from 'immutability-helper';

extend('$auto', (value, object) => {
  return object ? update(object, value) : update({}, value);
      Severity: Minor
      Found in front/src/actions/house.js - About 3 hrs to fix

        Function deleteHouse has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async deleteHouse(state, houseIndex) {
      store.setState({
        houseUpdateStatus: RequestStatus.Getting
      });
      const house = state.houses[houseIndex];
        Severity: Minor
        Found in front/src/actions/house.js - About 1 hr to fix

          Function editRoom has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              editRoom(state, houseIndex, roomIndex, property, value) {
          Severity: Minor
          Found in front/src/actions/house.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                updateHouseAlarmCode(state, code, houseIndex) {
      const newState = update(state, {
        houses: {
          [houseIndex]: {
            alarm_code: {
            Severity: Major
            Found in front/src/actions/house.js and 1 other location - About 1 hr to fix
            front/src/actions/house.js on lines 55..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                updateHouseName(state, name, houseIndex) {
      const newState = update(state, {
        houses: {
          [houseIndex]: {
            name: {
            Severity: Major
            Found in front/src/actions/house.js and 1 other location - About 1 hr to fix
            front/src/actions/house.js on lines 67..78

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 22 locations. Consider refactoring.
            Open

                async changeOrderDir(state, e) {
      store.setState({
        getHousesOrderDir: e.target.value
      });
      await actions.getHouses(store.getState());
            Severity: Major
            Found in front/src/actions/house.js and 21 other locations - About 1 hr to fix
            front/src/actions/house.js on lines 43..48
            front/src/actions/scene.js on lines 34..39
            front/src/actions/scene.js on lines 40..45
            front/src/routes/integration/all/broadlink/device-page/actions.js on lines 69..74
            front/src/routes/integration/all/broadlink/device-page/actions.js on lines 75..80
            front/src/routes/integration/all/ewelink/actions.js on lines 197..202
            front/src/routes/integration/all/ewelink/actions.js on lines 203..208
            front/src/routes/integration/all/mqtt/device-page/actions.js on lines 65..70
            front/src/routes/integration/all/mqtt/device-page/actions.js on lines 71..76
            front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 107..112
            front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 113..118
            front/src/routes/integration/all/rtsp-camera/actions.js on lines 240..245
            front/src/routes/integration/all/rtsp-camera/actions.js on lines 246..251
            front/src/routes/integration/all/tasmota/actions.js on lines 122..127
            front/src/routes/integration/all/tasmota/actions.js on lines 128..133
            front/src/routes/integration/all/tp-link/device-page/actions.js on lines 105..110
            front/src/routes/integration/all/tp-link/device-page/actions.js on lines 111..116
            front/src/routes/integration/all/xiaomi/actions.js on lines 98..103
            front/src/routes/integration/all/xiaomi/actions.js on lines 104..109
            front/src/routes/integration/all/zwave/node-page/actions.js on lines 71..76
            front/src/routes/integration/all/zwave/node-page/actions.js on lines 77..82

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 22 locations. Consider refactoring.
            Open

                async search(state, e) {
      store.setState({
        housesSearch: e.target.value
      });
      await actions.getHouses(store.getState());
            Severity: Major
            Found in front/src/actions/house.js and 21 other locations - About 1 hr to fix
            front/src/actions/house.js on lines 49..54
            front/src/actions/scene.js on lines 34..39
            front/src/actions/scene.js on lines 40..45
            front/src/routes/integration/all/broadlink/device-page/actions.js on lines 69..74
            front/src/routes/integration/all/broadlink/device-page/actions.js on lines 75..80
            front/src/routes/integration/all/ewelink/actions.js on lines 197..202
            front/src/routes/integration/all/ewelink/actions.js on lines 203..208
            front/src/routes/integration/all/mqtt/device-page/actions.js on lines 65..70
            front/src/routes/integration/all/mqtt/device-page/actions.js on lines 71..76
            front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 107..112
            front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 113..118
            front/src/routes/integration/all/rtsp-camera/actions.js on lines 240..245
            front/src/routes/integration/all/rtsp-camera/actions.js on lines 246..251
            front/src/routes/integration/all/tasmota/actions.js on lines 122..127
            front/src/routes/integration/all/tasmota/actions.js on lines 128..133
            front/src/routes/integration/all/tp-link/device-page/actions.js on lines 105..110
            front/src/routes/integration/all/tp-link/device-page/actions.js on lines 111..116
            front/src/routes/integration/all/xiaomi/actions.js on lines 98..103
            front/src/routes/integration/all/xiaomi/actions.js on lines 104..109
            front/src/routes/integration/all/zwave/node-page/actions.js on lines 71..76
            front/src/routes/integration/all/zwave/node-page/actions.js on lines 77..82

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              houses.forEach(house => house.rooms.sort((r1, r2) => r1.name.localeCompare(r2.name)));
            Severity: Minor
            Found in front/src/actions/house.js and 1 other location - About 40 mins to fix
            front/src/components/house/RoomSelector.jsx on lines 49..49

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status