Sign upLogin

GladysProject/Gladys

View on GitHub
Star
front/src/actions/signup/signupConfigureHouse.js

Summary

Maintainability
C
1 day
Test Coverage

Function createActions has 120 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createActions(store) {
  const actions = {
    initRoomList() {
      store.setState({
        signupRooms: []
Severity: Major
Found in front/src/actions/signup/signupConfigureHouse.js - About 4 hrs to fix

    Function createActions has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function createActions(store) {
  const actions = {
    initRoomList() {
      store.setState({
        signupRooms: []
    Severity: Minor
    Found in front/src/actions/signup/signupConfigureHouse.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function saveHouse has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async saveHouse(state) {
      // validate new house
      let errored = false;
      const errors = {};
      if (!state.signupNewHouseName || state.signupNewHouseName.length === 0) {
    Severity: Minor
    Found in front/src/actions/signup/signupConfigureHouse.js - About 1 hr to fix

      Function initLeafletMap has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async initLeafletMap(state) {
      if (state.signupHouseLeafletMap) {
        state.signupHouseLeafletMap.remove();
      }
      const leafletMap = leaflet.map('select-house-location-map').setView([48.8583, 2.2945], 2);
      Severity: Minor
      Found in front/src/actions/signup/signupConfigureHouse.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        const icon = leaflet.icon({
  iconUrl: '/assets/leaflet/marker-icon.png',
  iconRetinaUrl: '/assets/leaflet/marker-icon-2x.png',
  shadowUrl: '/assets/leaflet/marker-shadow.png',
  iconSize: [25, 41],
        Severity: Major
        Found in front/src/actions/signup/signupConfigureHouse.js and 1 other location - About 2 hrs to fix
        front/src/components/house/Map.jsx on lines 4..13

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status