Sign upLogin

GladysProject/Gladys

View on GitHub
Star
front/src/routes/integration/all/tp-link/device-page/actions.js

Summary

Maintainability
D
3 days
Test Coverage

Function createActions has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createActions(store) {
  const houseActions = createActionsHouse(store);
  const integrationActions = createActionsIntegration(store);
  const actions = {
    async getTpLinkDevices(state) {
Severity: Major
Found in front/src/routes/integration/all/tp-link/device-page/actions.js - About 4 hrs to fix

    Function createActions has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    function createActions(store) {
  const houseActions = createActionsHouse(store);
  const integrationActions = createActionsIntegration(store);
  const actions = {
    async getTpLinkDevices(state) {
    Severity: Minor
    Found in front/src/routes/integration/all/tp-link/device-page/actions.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        async getTpLinkNewDevices(state) {
      store.setState({
        getTpLinkNewDevicesStatus: RequestStatus.Getting
      });
      try {
    Severity: Major
    Found in front/src/routes/integration/all/tp-link/device-page/actions.js and 1 other location - About 6 hrs to fix
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 39..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 170.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        async createDevice(state, device) {
      store.setState({
        getTpLinkCreateDeviceStatus: RequestStatus.Getting
      });
      try {
    Severity: Major
    Found in front/src/routes/integration/all/tp-link/device-page/actions.js and 1 other location - About 4 hrs to fix
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 70..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        async deleteDevice(state, device, index) {
      await state.httpClient.delete(`/api/v1/device/${device.selector}`);
      const newState = update(state, {
        tpLinkDevices: {
          $splice: [[index, 1]]
    Severity: Major
    Found in front/src/routes/integration/all/tp-link/device-page/actions.js and 7 other locations - About 2 hrs to fix
    front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 47..55
    front/src/routes/integration/all/broadlink/device-page/actions.js on lines 60..68
    front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 62..70
    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 56..64
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 98..106
    front/src/routes/integration/all/xiaomi/actions.js on lines 77..85
    front/src/routes/integration/all/zwave/node-page/actions.js on lines 46..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        async saveDevice(state, device, index) {
      const savedDevice = await state.httpClient.post('/api/v1/device', device);
      const newState = update(state, {
        tpLinkDevices: {
          $splice: [[index, 1, savedDevice]]
    Severity: Major
    Found in front/src/routes/integration/all/tp-link/device-page/actions.js and 3 other locations - About 1 hr to fix
    front/src/routes/integration/all/broadlink/device-page/actions.js on lines 51..59
    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 35..43
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 61..69

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        updateDeviceProperty(state, index, property, value) {
      const newState = update(state, {
        tpLinkDevices: {
          [index]: {
            [property]: {
    Severity: Major
    Found in front/src/routes/integration/all/tp-link/device-page/actions.js and 7 other locations - About 1 hr to fix
    front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 35..46
    front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 50..61
    front/src/routes/integration/all/lan-manager/discover-page/actions.js on lines 115..126
    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 44..55
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 86..97
    front/src/routes/integration/all/xiaomi/actions.js on lines 86..97
    front/src/routes/integration/all/zwave/node-page/actions.js on lines 34..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 22 locations. Consider refactoring.
    Open

        async search(state, e) {
      store.setState({
        tpLinkDeviceSearch: e.target.value
      });
      await actions.getTpLinkDevices(store.getState());
    Severity: Major
    Found in front/src/routes/integration/all/tp-link/device-page/actions.js and 21 other locations - About 1 hr to fix
    front/src/actions/house.js on lines 43..48
    front/src/actions/house.js on lines 49..54
    front/src/actions/scene.js on lines 34..39
    front/src/actions/scene.js on lines 40..45
    front/src/routes/integration/all/broadlink/device-page/actions.js on lines 69..74
    front/src/routes/integration/all/broadlink/device-page/actions.js on lines 75..80
    front/src/routes/integration/all/ewelink/actions.js on lines 197..202
    front/src/routes/integration/all/ewelink/actions.js on lines 203..208
    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 65..70
    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 71..76
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 107..112
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 113..118
    front/src/routes/integration/all/rtsp-camera/actions.js on lines 240..245
    front/src/routes/integration/all/rtsp-camera/actions.js on lines 246..251
    front/src/routes/integration/all/tasmota/actions.js on lines 122..127
    front/src/routes/integration/all/tasmota/actions.js on lines 128..133
    front/src/routes/integration/all/tp-link/device-page/actions.js on lines 111..116
    front/src/routes/integration/all/xiaomi/actions.js on lines 98..103
    front/src/routes/integration/all/xiaomi/actions.js on lines 104..109
    front/src/routes/integration/all/zwave/node-page/actions.js on lines 71..76
    front/src/routes/integration/all/zwave/node-page/actions.js on lines 77..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 22 locations. Consider refactoring.
    Open

        async changeOrderDir(state, e) {
      store.setState({
        getTpLinkDeviceOrderDir: e.target.value
      });
      await actions.getTpLinkDevices(store.getState());
    Severity: Major
    Found in front/src/routes/integration/all/tp-link/device-page/actions.js and 21 other locations - About 1 hr to fix
    front/src/actions/house.js on lines 43..48
    front/src/actions/house.js on lines 49..54
    front/src/actions/scene.js on lines 34..39
    front/src/actions/scene.js on lines 40..45
    front/src/routes/integration/all/broadlink/device-page/actions.js on lines 69..74
    front/src/routes/integration/all/broadlink/device-page/actions.js on lines 75..80
    front/src/routes/integration/all/ewelink/actions.js on lines 197..202
    front/src/routes/integration/all/ewelink/actions.js on lines 203..208
    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 65..70
    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 71..76
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 107..112
    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 113..118
    front/src/routes/integration/all/rtsp-camera/actions.js on lines 240..245
    front/src/routes/integration/all/rtsp-camera/actions.js on lines 246..251
    front/src/routes/integration/all/tasmota/actions.js on lines 122..127
    front/src/routes/integration/all/tasmota/actions.js on lines 128..133
    front/src/routes/integration/all/tp-link/device-page/actions.js on lines 105..110
    front/src/routes/integration/all/xiaomi/actions.js on lines 98..103
    front/src/routes/integration/all/xiaomi/actions.js on lines 104..109
    front/src/routes/integration/all/zwave/node-page/actions.js on lines 71..76
    front/src/routes/integration/all/zwave/node-page/actions.js on lines 77..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status