Sign upLogin

GladysProject/Gladys

View on GitHub
Star
front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js

Summary

Maintainability
D
1 day
Test Coverage

Function createActions has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createActions(store) {
  const integrationActions = createActionsIntegration(store);
  const houseActions = createActionsHouse(store);
  const actions = {
    async getZigbee2mqttDevices(state, take, skip) {
Severity: Major
Found in front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js - About 4 hrs to fix

    Function getZigbee2mqttDevices has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async getZigbee2mqttDevices(state, take, skip) {
      store.setState({
        getZigbee2mqttStatus: RequestStatus.Getting
      });
      try {
    Severity: Minor
    Found in front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js - About 1 hr to fix

      Function createActions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function createActions(store) {
  const integrationActions = createActionsIntegration(store);
  const houseActions = createActionsHouse(store);
  const actions = {
    async getZigbee2mqttDevices(state, take, skip) {
      Severity: Minor
      Found in front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          async deleteDevice(state, index) {
      const device = state.zigbee2mqttDevices[index];
      if (device.created_at) {
        await state.httpClient.delete(`/api/v1/device/${device.selector}`);
      }
      Severity: Major
      Found in front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js and 3 other locations - About 3 hrs to fix
      front/src/routes/integration/all/ewelink/actions.js on lines 185..196
      front/src/routes/integration/all/rtsp-camera/actions.js on lines 214..225
      front/src/routes/integration/all/tasmota/actions.js on lines 110..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          updateDeviceField(state, index, field, value) {
      const zigbee2mqttDevices = update(state.zigbee2mqttDevices, {
        [index]: {
          [field]: {
            $set: value
      Severity: Major
      Found in front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js and 3 other locations - About 1 hr to fix
      front/src/routes/integration/all/broadlink/device-page/actions.js on lines 93..105
      front/src/routes/integration/all/rtsp-camera/actions.js on lines 140..151
      front/src/routes/integration/all/zigbee2mqtt/discover-page/actions.js on lines 85..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          async search(state, e) {
      store.setState({
        zigbee2mqttSearch: e.target.value
      });
      await actions.getZigbee2mqttDevices(store.getState(), 20, 0);
      Severity: Major
      Found in front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js and 5 other locations - About 1 hr to fix
      front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 56..61
      front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 62..67
      front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 71..76
      front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 77..82
      front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js on lines 110..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          async changeOrderDir(state, e) {
      store.setState({
        getZigbee2mqttOrderDir: e.target.value
      });
      await actions.getZigbee2mqttDevices(store.getState(), 20, 0);
      Severity: Major
      Found in front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js and 5 other locations - About 1 hr to fix
      front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 56..61
      front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 62..67
      front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 71..76
      front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 77..82
      front/src/routes/integration/all/zigbee2mqtt/device-page/actions.js on lines 104..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status