Sign upLogin

GladysProject/Gladys

View on GitHub
Star
server/api/controllers/dashboard.controller.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function DashboardController has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function DashboardController(gladys) {
  /**
   * @api {post} /api/v1/dashboard create
   * @apiName createDashoard
   * @apiGroup Dashboard
Severity: Minor
Found in server/api/controllers/dashboard.controller.js - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      async function create(req, res) {
    const dashboard = await gladys.dashboard.create(req.user.id, req.body);
    res.status(201).json(dashboard);
  }
    Severity: Major
    Found in server/api/controllers/dashboard.controller.js and 3 other locations - About 1 hr to fix
    server/api/controllers/calendar.controller.js on lines 103..106
    server/api/controllers/location.controller.js on lines 13..16
    server/api/controllers/room.controller.js on lines 25..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      async function getBySelector(req, res) {
    const dashboard = await gladys.dashboard.getBySelector(req.user.id, req.params.dashboard_selector);
    res.json(dashboard);
  }
    Severity: Major
    Found in server/api/controllers/dashboard.controller.js and 6 other locations - About 1 hr to fix
    server/api/controllers/gateway.controller.js on lines 19..22
    server/api/controllers/house.controller.js on lines 115..118
    server/api/controllers/house.controller.js on lines 155..158
    server/api/controllers/service.controller.js on lines 71..74
    server/api/controllers/session.controller.js on lines 9..12
    server/api/controllers/variable.controller.js on lines 41..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      async function destroy(req, res) {
    await gladys.dashboard.destroy(req.user.id, req.params.dashboard_selector);
    res.json({
      success: true,
    });
    Severity: Major
    Found in server/api/controllers/dashboard.controller.js and 1 other location - About 1 hr to fix
    server/api/controllers/gateway.controller.js on lines 41..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      async function get(req, res) {
    const dashboards = await gladys.dashboard.get(req.user.id);
    res.json(dashboards);
  }
    Severity: Major
    Found in server/api/controllers/dashboard.controller.js and 6 other locations - About 55 mins to fix
    server/api/controllers/house.controller.js on lines 63..66
    server/api/controllers/house.controller.js on lines 125..128
    server/api/controllers/house.controller.js on lines 145..148
    server/api/controllers/house.controller.js on lines 165..168
    server/api/controllers/scene.controller.js on lines 54..57
    server/api/controllers/user.controller.js on lines 78..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status