Sign upLogin

GladysProject/Gladys

View on GitHub
Star
server/api/controllers/service.controller.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function ServiceController has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function ServiceController(gladys) {
  /**
   * @api {post} /api/v1/service/:service_name/start start
   * @apiName start
   * @apiGroup Service
Severity: Minor
Found in server/api/controllers/service.controller.js - About 1 hr to fix

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      async function getByName(req, res) {
    const service = await gladys.service.getByName(req.params.service_name, req.query.pod_id);
    res.json(service);
  }
    Severity: Major
    Found in server/api/controllers/service.controller.js and 6 other locations - About 1 hr to fix
    server/api/controllers/dashboard.controller.js on lines 71..74
    server/api/controllers/gateway.controller.js on lines 19..22
    server/api/controllers/house.controller.js on lines 115..118
    server/api/controllers/house.controller.js on lines 155..158
    server/api/controllers/session.controller.js on lines 9..12
    server/api/controllers/variable.controller.js on lines 41..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      async function getAll(req, res) {
    const service = await gladys.service.getAll(req.query.pod_id);
    res.json(service);
  }
    Severity: Major
    Found in server/api/controllers/service.controller.js and 3 other locations - About 50 mins to fix
    server/api/controllers/area.controller.js on lines 111..114
    server/api/controllers/house.controller.js on lines 175..178
    server/api/controllers/message.controller.js on lines 44..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      return Object.freeze({
    start: asyncMiddleware(start),
    stop: asyncMiddleware(stop),
    getByName: asyncMiddleware(getByName),
    getAll: asyncMiddleware(getAll),
    Severity: Minor
    Found in server/api/controllers/service.controller.js and 1 other location - About 40 mins to fix
    server/api/controllers/variable.controller.js on lines 60..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status