Sign upLogin

GladysProject/Gladys

View on GitHub
Star
server/services/broadlink/api/broadlink.controller.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function BroadlinkController has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function BroadlinkController(broadlinkManager) {
  /**
   * @api {get} /api/v1/service/broadlink/peripheral Get discovered Broadlink peripherals.
   * @apiName getPeripheral
   * @apiGroup Broadlink
Severity: Minor
Found in server/services/broadlink/api/broadlink.controller.js - About 1 hr to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      async function learn(req, res) {
    await broadlinkManager.learn(req.body.peripheral);
    res.json({ learn: true });
  }
    Severity: Major
    Found in server/services/broadlink/api/broadlink.controller.js and 4 other locations - About 50 mins to fix
    server/services/broadlink/api/broadlink.controller.js on lines 27..30
    server/services/caldav/api/caldav.controller.js on lines 22..27
    server/services/rtsp-camera/api/rtspCamera.controller.js on lines 39..42
    server/services/rtsp-camera/api/rtspCamera.controller.js on lines 49..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      async function cancelLearn(req, res) {
    await broadlinkManager.cancelLearn(req.body.peripheral);
    res.json({ cancelLearn: true });
  }
    Severity: Major
    Found in server/services/broadlink/api/broadlink.controller.js and 4 other locations - About 50 mins to fix
    server/services/broadlink/api/broadlink.controller.js on lines 17..20
    server/services/caldav/api/caldav.controller.js on lines 22..27
    server/services/rtsp-camera/api/rtspCamera.controller.js on lines 39..42
    server/services/rtsp-camera/api/rtspCamera.controller.js on lines 49..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status