Sign upLogin

GladysProject/Gladys

View on GitHub
Star
server/services/node-red/api/node-red.controller.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function NodeRedController has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function NodeRedController(gladys, nodeRedManager) {
  /**
   * @api {get} /api/v1/service/node-red/status Get node-red connection status
   * @apiName status
   * @apiGroup Node-RED
Severity: Minor
Found in server/services/node-red/api/node-red.controller.js - About 1 hr to fix

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      async function installNodeRedContainer(req, res) {
    logger.debug('Install Node-RED container');
    await nodeRedManager.installContainer();
    res.json({
      success: true,
    Severity: Major
    Found in server/services/node-red/api/node-red.controller.js and 6 other locations - About 55 mins to fix
    server/services/node-red/api/node-red.controller.js on lines 21..27
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 67..73
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 80..86
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 93..99
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 106..112
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 119..125

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

      async function connect(req, res) {
    logger.debug('Entering connect step');
    await nodeRedManager.init();
    res.json({
      success: true,
    Severity: Major
    Found in server/services/node-red/api/node-red.controller.js and 6 other locations - About 55 mins to fix
    server/services/node-red/api/node-red.controller.js on lines 34..40
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 67..73
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 80..86
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 93..99
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 106..112
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 119..125

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      async function status(req, res) {
    logger.debug('Get status');
    const response = await nodeRedManager.status();
    res.json(response);
  }
    Severity: Major
    Found in server/services/node-red/api/node-red.controller.js and 2 other locations - About 50 mins to fix
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 33..37
    server/services/zigbee2mqtt/api/zigbee2mqtt.controller.js on lines 44..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status