Glamping-Hub/django-painless-seo

View on GitHub

Showing 2 of 2 total issues

Function update_seo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def update_seo(sender, instance, **kwargs):
    active_lang = get_language()
    sites = Site.objects.all()
    for lang_code, lang_name in settings.SEO_LANGUAGES:
        activate(lang_code)
Severity: Minor
Found in painlessseo/models.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_required_fields has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_required_fields(self, cleaned_data, fields):
        error_msg = _(u'This field is required')
        for field in fields:
            value = cleaned_data.get(field)
            if not value:
Severity: Minor
Found in painlessseo/admin.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language