Sign upLogin

GlobalNamesArchitecture/dwca-hunter

View on GitHub
Star

Showing 91 of 144 total issues

Method generate_dwca has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def generate_dwca
      DwcaHunter.logger_write(object_id,
                              "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/parentNameUsageID",
Severity: Major
Found in lib/dwca_hunter/resources/itis.rb - About 2 hrs to fix

    Method generate_dwca has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def generate_dwca
      DwcaHunter.logger_write(object_id, "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/scientificName",
                "http://rs.tdwg.org/dwc/terms/kingdom",
    Severity: Minor
    Found in lib/dwca_hunter/resources/tpt.rb - About 2 hrs to fix

      Method enrich_data has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def enrich_data
      DwcaHunter.logger_write(object_id,
                              "Extracting data from xml file...")
      Dir.chdir(@download_dir)
      f = open("data.xml", "r:utf-8")
      Severity: Minor
      Found in lib/dwca_hunter/resources/wikispecies.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method collect_names has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def collect_names
      file = CSV.open(File.join(@download_dir, "data.csv"),
                      headers: true)
      file.each_with_index do |row, i|
        kingdom = "Animalia"
      Severity: Minor
      Found in lib/dwca_hunter/resources/how-moore-birds.rb - About 1 hr to fix

        Method generate_dwca has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def generate_dwca
      DwcaHunter.logger_write(object_id,
                              "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/scientificName",
        Severity: Minor
        Found in lib/dwca_hunter/resources/how-moore-birds.rb - About 1 hr to fix

          Method generate_dwca has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def generate_dwca
      DwcaHunter.logger_write(object_id,
                              "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/scientificName",
          Severity: Minor
          Found in lib/dwca_hunter/resources/mcz.rb - About 1 hr to fix

            Method collect_names has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def collect_names
      tpt_dir = "tpt-taxonomy-main"
      tpt_path = File.join(@download_dir, tpt_dir)
      @names_index = {}
      files = Dir.entries(tpt_path)
            Severity: Minor
            Found in lib/dwca_hunter/resources/tpt.rb - About 1 hr to fix

              Method generate_dwca has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def generate_dwca
      DwcaHunter.logger_write(object_id,
                              "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/scientificName",
              Severity: Minor
              Found in lib/dwca_hunter/resources/freebase.rb - About 1 hr to fix

                Method get_names has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def get_names
      # 0    tsn serial not null
      # 1    unit_ind1 char(1)
      # 2    unit_name1 char(35) not null
      # 3    unit_ind2 char(1)
                Severity: Minor
                Found in lib/dwca_hunter/resources/itis.rb - About 1 hr to fix

                  Method collect_names has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def collect_names
      @names_index = {}
      file = CSV.open(File.join(@download_dir, find_csv_file),
                      headers: true, col_sep: "|", quote_char: "\b")
      file.each do |row|
                  Severity: Minor
                  Found in lib/dwca_hunter/resources/wcvp.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method collect_names has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def collect_names
      @names_index = {}
      file = CSV.open(File.join(@download_dir, "data.tsv"),
                      headers: true, col_sep: "\t", quote_char: "\b")
      file.each_with_index do |row, i|
                  Severity: Minor
                  Found in lib/dwca_hunter/resources/fungal_names.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method organize_data has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def organize_data
      @data = JSON.load(open(@download_path, "r:utf-8").read)
      @data.each do |d|
        scientific_name = d["scientific_name"].to_s
        id = d["id"]
                  Severity: Minor
                  Found in lib/dwca_hunter/resources/freebase.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method process_hierarchy has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def process_hierarchy(rec)
      parent_id = @clades["Mammalia"][:id]
      is_row_rank = false
      %i[order suborder infraorder superfamily family
         subfamily tribe genus subgenus species subspecies].each do |rank|
                  Severity: Minor
                  Found in lib/dwca_hunter/resources/mammal_species.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method collect_names has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def collect_names
      @names_index = {}
      file = CSV.open(File.join(@download_dir, "data.csv"),
                      headers: true)
      file.each_with_index do |row, _i|
                  Severity: Minor
                  Found in lib/dwca_hunter/resources/aos-birds.rb - About 1 hr to fix

                    Method generate_dwca has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        def generate_dwca
      DwcaHunter.logger_write(object_id,
                              "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/scientificName",
                    Severity: Minor
                    Found in lib/dwca_hunter/resources/ion.rb - About 1 hr to fix

                      Method generate_dwca has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          def generate_dwca
      DwcaHunter.logger_write(object_id, "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonId",
                "http://rs.tdwg.org/dwc/terms/parentNameUsageId",
                "http://rs.tdwg.org/dwc/terms/scientificName",
                      Severity: Minor
                      Found in lib/dwca_hunter/resources/tropicos.rb - About 1 hr to fix

                        Method generate_dwca has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            def generate_dwca
      DwcaHunter.logger_write(object_id, "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/scientificName",
                "http://rs.tdwg.org/dwc/terms/acceptedNameUsageID",
                        Severity: Minor
                        Found in lib/dwca_hunter/resources/disc_life_bees.rb - About 1 hr to fix

                          Method generate_dwca has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              def generate_dwca
      DwcaHunter.logger_write(object_id, "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/scientificName",
                "http://rs.tdwg.org/dwc/terms/taxonRank",
                          Severity: Minor
                          Found in lib/dwca_hunter/resources/nom-zoologicus.rb - About 1 hr to fix

                            Method collect_names has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                def collect_names
      @names_index = {}
      file = CSV.open(File.join(@download_dir, find_csv_file),
        headers: true)
      file.each do |row|
                            Severity: Minor
                            Found in lib/dwca_hunter/resources/algaebase.rb - About 1 hr to fix

                              Method enrich_data has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  def enrich_data
      DwcaHunter.logger_write(object_id,
                              "Extracting data from xml file...")
      Dir.chdir(@download_dir)
      f = open("data.xml", "r:utf-8")
                              Severity: Minor
                              Found in lib/dwca_hunter/resources/wikispecies.rb - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language