Sign upLogin

GoBoundless/dyph3

View on GitHub
Star

Showing 6 of 10 total issues

Method interpret_chunk has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def interpret_chunk(chunk_desc)
          if chunk_desc.action == :choose_left
            # 0 flag means choose left.  put lines chunk_desc[1] .. chunk_desc[2] into the @result body.
            temp_text = accumulate_lines(chunk_desc.left_lo, chunk_desc.left_hi, @text3.left)
            # they deleted it, don't use if its only a new line
Severity: Minor
Found in lib/dyph/support/merger.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method change_or_delete has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def change_or_delete(old_text, line, prev_no_change_old, merged_text, index)
Severity: Minor
Found in lib/dyph/two_way_differs/output_converter.rb - About 35 mins to fix

    Method append_change_range has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def append_change_range(changes_ranges, left_lo, left_hi, right_lo, right_hi)
    Severity: Minor
    Found in lib/dyph/two_way_differs/heckel_diff.rb - About 35 mins to fix

      Method build_result_queue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def build_result_queue(diffs_queue, prev_base_hi, result_queue)
          #current side can be :left or :right
          if queue_finished?(diffs_queue.peek, prev_base_hi)
            result_queue
          else
      Severity: Minor
      Found in lib/dyph/support/diff3.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method choose_side has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def choose_side
        if empty? :left
          @current_side = :right
        elsif empty? :right
          @current_side = :left
      Severity: Minor
      Found in lib/dyph/support/diff3.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method collate_merge has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def collate_merge(merge_result, join_function, conflict_handler)
        if merge_result.empty?
          Dyph::MergeResult.new([Outcome::Resolved.new([])], join_function)
        else
          merge_result = combine_non_conflicts(merge_result)
      Severity: Minor
      Found in lib/dyph/support/collater.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language