Sign upLogin

GoVanguard/pyShodan

View on GitHub
Star

Showing 5 of 5 total issues

Function searchList has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def searchList(self, inputFile: str) -> Union[List[dict], str]:
        if not self.shodanSession:
            return 'Set API Key'

        if not inputFile:
Severity: Minor
Found in pyShodan/__init__.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return f"Error: {e}"
Severity: Major
Found in pyShodan/__init__.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return f"Error: {e}"
Severity: Major
Found in pyShodan/__init__.py - About 30 mins to fix

Avoid too many return statements within this function.
Open

                return [[item['ip_str'], item['org'], item['data'].replace(',', ' ').strip(), item['port']] for item in apiResult['data']]
Severity: Major
Found in pyShodan/__init__.py - About 30 mins to fix

Function searchIp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def searchIp(self, searchHost: str, allData: bool = False) -> Union[List[dict], str]:
        if not self.shodanSession:
            return 'Set API Key'

        if not searchHost:
Severity: Minor
Found in pyShodan/__init__.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language