Godley/MuseParse

View on GitHub

Showing 228 of 691 total issues

Function HandleMeasures has a Cognitive Complexity of 361 (exceeds 5 allowed). Consider refactoring.
Open

def HandleMeasures(tag, attrib, content, piece, data):
    part_id = helpers.GetID(attrib, "part", "id")
    measure_id = IdAsInt(helpers.GetID(attrib, "measure", "number"))
    part = None
    key = None
Severity: Minor
Found in MuseParse/classes/Input/MxmlParser.py - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function HandleDirections has a Cognitive Complexity of 204 (exceeds 5 allowed). Consider refactoring.
Open

def HandleDirections(tags, attrs, chars, piece, data):
    global expressions, items
    return_val = None
    if len(tags) == 0:
        return None
Severity: Minor
Found in MuseParse/classes/Input/MxmlParser.py - About 4 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SetupPiece has a Cognitive Complexity of 202 (exceeds 5 allowed). Consider refactoring.
Open

def SetupPiece(tag, attrib, content, piece, data):
    return_val = None
    if content is not [] and len(tag) > 0:
        title = None
        composer = None
Severity: Minor
Found in MuseParse/classes/Input/MxmlParser.py - About 4 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MxmlParser.py has 1403 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import xml.sax
from xml.sax import make_parser, handler
import copy

from MuseParse.classes.ObjectHierarchy.ItemClasses import Directions, Key, BarlinesAndMarkers, Clef, Meter, \
Severity: Major
Found in MuseParse/classes/Input/MxmlParser.py - About 3 days to fix

    Function handleBarline has a Cognitive Complexity of 99 (exceeds 5 allowed). Consider refactoring.
    Open

    def handleBarline(tag, attrib, content, piece, data):
        part_id = helpers.GetID(attrib, "part", "id")
        measure_id = IdAsInt(helpers.GetID(attrib, "measure", "number"))
        measure = None
        times = 2
    Severity: Minor
    Found in MuseParse/classes/Input/MxmlParser.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function RunNoteChecks has a Cognitive Complexity of 86 (exceeds 5 allowed). Consider refactoring.
    Open

        def RunNoteChecks(self):
            children = self.GetChildrenIndexes()
            previous = None
            for child in range(len(children)):
                note = self.GetChild(children[child])
    Severity: Minor
    Found in MuseParse/classes/ObjectHierarchy/TreeClasses/VoiceNode.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addNote has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring.
    Open

        def addNote(self, item, voice=1, increment=1, chord=False):
            shift = 0
            # get the appropriate voice
            if self.getVoice(voice) is None:
                self.addVoice(VoiceNode(), voice)
    Severity: Minor
    Found in MuseParse/classes/ObjectHierarchy/TreeClasses/MeasureNode.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Note.py has 686 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import math
    
    from MuseParse.classes.ObjectHierarchy.ItemClasses import BaseClass, Mark, Ornaments
    
    
    
    Severity: Major
    Found in MuseParse/classes/ObjectHierarchy/ItemClasses/Note.py - About 1 day to fix

      File Directions.py has 649 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import string
      import random
      
      from MuseParse.classes.ObjectHierarchy.ItemClasses import BaseClass
      
      
      Severity: Major
      Found in MuseParse/classes/ObjectHierarchy/ItemClasses/Directions.py - About 1 day to fix

        Function CreateNote has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
        Open

        def CreateNote(tag, attrs, content, piece, data):
            ret_value = None
        
            if len(tag) > 0 and "note" in tag:
        
        
        Severity: Minor
        Found in MuseParse/classes/Input/MxmlParser.py - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File MeasureNode.py has 554 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import copy
        
        from MuseParse.classes.ObjectHierarchy.TreeClasses.BaseTree import IndexedNode, BackwardSearch, Search
        
        from MuseParse.classes.ObjectHierarchy.TreeClasses.VoiceNode import VoiceNode
        Severity: Major
        Found in MuseParse/classes/ObjectHierarchy/TreeClasses/MeasureNode.py - About 1 day to fix

          Function handleArticulation has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
          Open

          def handleArticulation(tag, attrs, content, piece, data):
              if len(tag) > 0:
                  if "articulations" in tag:
                      if data["note"] is not None:
                          accent = None
          Severity: Minor
          Found in MuseParse/classes/Input/MxmlParser.py - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function HandleRepeatMarking has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
          Open

          def HandleRepeatMarking(tags, attrs, chars, piece, data):
              global last_note
              if "direction" in tags or "forward" in tags:
                  if tags[-1] == "voice":
                      data["voice"] = int(chars["voice"])
          Severity: Minor
          Found in MuseParse/classes/Input/MxmlParser.py - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function UpdatePart has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
          Open

          def UpdatePart(tag, attrib, content, piece, data):
              part_id = helpers.GetID(attrib, "part", "id")
              if part_id is None:
                  part_id = helpers.GetID(attrib, "score-part", "id")
              return_val = None
          Severity: Minor
          Found in MuseParse/classes/Input/MxmlParser.py - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function EndTag has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
          Open

              def EndTag(self, name):
                  '''
                  Method called by the SAX parser when a tag is ended
          
                  :param name: the name of the tag
          Severity: Minor
          Found in MuseParse/classes/Input/MxmlParser.py - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleClef has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
          Open

          def handleClef(tag, attrib, content, piece, data):
              data["staff_id"] = IdAsInt(helpers.GetID(attrib, "clef", "number"))
              if data["staff_id"] is None:
                  data["staff_id"] = 1
              measure_id = IdAsInt(helpers.GetID(attrib, "measure", "number"))
          Severity: Minor
          Found in MuseParse/classes/Input/MxmlParser.py - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __str__ has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
          Open

              def __str__(self):
                  st = str(type(self))
                  values = vars(self)
                  for key in values.keys():
                      if key == "indent":
          Severity: Minor
          Found in MuseParse/classes/ObjectHierarchy/ItemClasses/BaseClass.py - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getLilyDuration has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
          Open

              def getLilyDuration(self):
                  """
                  method to calculate duration of note in lilypond duration style
                  :return:
                  """
          Severity: Minor
          Found in MuseParse/classes/ObjectHierarchy/ItemClasses/Note.py - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function BackwardSearch has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
          Open

          def BackwardSearch(cls_type, node, index, depth=0, start_index=0):
              '''
              Helper method which backwards-recursively searches for objects
              :param cls_type: class type of the object we are in search of
              :param node: object instance to start at
          Severity: Minor
          Found in MuseParse/classes/ObjectHierarchy/TreeClasses/BaseTree.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleOrnaments has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
          Open

          def handleOrnaments(tags, attrs, content, piece, data):
              if "ornaments" in tags:
                  if tags[-1] == "inverted-mordent":
                      data["note"].addNotation(Ornaments.InvertedMordent())
                  if tags[-1] == "mordent":
          Severity: Minor
          Found in MuseParse/classes/Input/MxmlParser.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language