Sign upLogin

GordonDiggs/rayons

View on GitHub
Star

Showing 4 of 143 total issues

File discogs_importer_spec.rb has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "spec_helper"

describe DiscogsImporter, type: :model do
  describe "#import" do
    it "handles odd formats" do
Severity: Minor
Found in spec/models/discogs_importer_spec.rb - About 2 hrs to fix

    Method advanced_search has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.advanced_search(query = {})
    if !query.present?
      all
    else
      query = query.select { |_term, value| value.present? }
    Severity: Minor
    Found in app/models/item.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method item_description has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def item_description
    result = "<speak>"
    if intent == INTENTS[:stop]
      result << "<p>Happy listening!</p>"
    elsif item
    Severity: Minor
    Found in app/models/item_alexa_presenter.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sort has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      sort: function(e) {
    var $this = $(e.target),
        direction = $('table').data('direction'),
        current_sort = $('table').data('sort');
    Severity: Minor
    Found in app/assets/javascripts/rayons.ui.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language