Sign upLogin

HumanCellAtlas/ingest-broker

View on GitHub
Star

Showing 6 of 144 total issues

File summary_service.py has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import os
from functools import reduce
from typing import Generator
from typing import Iterable
Severity: Minor
Found in broker/service/summary_service.py - About 2 hrs to fix

    Function generateApplyFunction has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

            def generateApplyFunction(self):
            """
            If an identifier is specified, we want the following algorithm:
            - return entities matching the identifier
    Severity: Minor
    Found in broker/service/summary_service.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_spreadsheet_location has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_spreadsheet_location(self, submission_uuid):
        submission_dir_path = f'{self.storage_dir}/{submission_uuid}'
        storage_manifest_path = f'{submission_dir_path}/{self.storage_manifest_name}'
        if not os.path.isdir(submission_dir_path):
            raise SubmissionSpreadsheetDoesntExist()
    Severity: Minor
    Found in broker/service/spreadsheet_storage/spreadsheet_storage_service.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, biomaterials=None, projects=None, processes=None, protocols=None, files=None):
    Severity: Minor
    Found in broker/service/summary_service.py - About 35 mins to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, placeholder, entity_type, identifier, path, post_process):
      Severity: Minor
      Found in broker/service/summary_service.py - About 35 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def __init__(self, placeholder=None, entity_type=None, identifier=None, paths=None, reducer=None):
        Severity: Minor
        Found in broker/service/summary_service.py - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language