Sign upLogin

ICTU/quality-time

View on GitHub
Star
components/frontend/src/dashboard/StatusBarChart.js

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

StatusBarChart.propTypes = {
    animate: object,
    colors: stringsPropType,
    label: labelPropType,
    tooltip: object,
Severity: Major
Found in components/frontend/src/dashboard/StatusBarChart.js and 4 other locations - About 1 hr to fix
components/frontend/src/dashboard/StatusPieChart.js on lines 47..57
components/frontend/src/fields/MultipleChoiceInput.js on lines 74..84
components/frontend/src/fields/StringInput.js on lines 46..56
components/frontend/src/source/SourceEntityDetails.js on lines 127..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export function StatusBarChart({ animate, colors, label, tooltip, summary, maxY, style, width, height }) {
    const nrMetrics = sum(summary[Object.keys(summary)[0]])
    const nrDates = Object.keys(summary).length
    // Calculate how many metrics this chart displays compared to the chart with the most metrics.
    // The ratio is used below to set the bar width so that bars in charts that represent fewer
Severity: Major
Found in components/frontend/src/dashboard/StatusBarChart.js and 3 other locations - About 40 mins to fix
components/frontend/src/dashboard/StatusPieChart.js on lines 15..46
components/frontend/src/source/Source.js on lines 64..116
components/frontend/src/source/SourceEntityDetails.js on lines 53..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status