ICTU/quality-time

View on GitHub
components/frontend/src/metric/MetricDetails.test.js

Summary

Maintainability
D
2 days
Test Coverage

Function renderMetricDetails has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function renderMetricDetails(stopFilteringAndSorting, connection_error) {
    measurement_api.get_metric_measurements.mockImplementation(() =>
        Promise.resolve({
            ok: true,
            measurements: [
Severity: Minor
Found in components/frontend/src/metric/MetricDetails.test.js - About 1 hr to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    it("switches tabs to the share tab", async () => {
        await renderMetricDetails()
        expect(screen.getAllByText(/Metric name/).length).toBe(1)
        fireEvent.click(screen.getByText(/Share/))
        expect(screen.getAllByText(/Metric permanent link/).length).toBe(1)
    Severity: Major
    Found in components/frontend/src/metric/MetricDetails.test.js and 4 other locations - About 2 hrs to fix
    components/frontend/src/metric/MetricDetails.test.js on lines 105..110
    components/frontend/src/metric/MetricDetails.test.js on lines 112..117
    components/frontend/src/metric/MetricDetails.test.js on lines 119..124
    components/frontend/src/metric/MetricDetails.test.js on lines 126..131

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    it("switches tabs", async () => {
        await renderMetricDetails()
        expect(screen.getAllByText(/Metric name/).length).toBe(1)
        fireEvent.click(screen.getByText(/Sources/))
        expect(screen.getAllByText(/Source name/).length).toBe(1)
    Severity: Major
    Found in components/frontend/src/metric/MetricDetails.test.js and 4 other locations - About 2 hrs to fix
    components/frontend/src/metric/MetricDetails.test.js on lines 112..117
    components/frontend/src/metric/MetricDetails.test.js on lines 119..124
    components/frontend/src/metric/MetricDetails.test.js on lines 126..131
    components/frontend/src/metric/MetricDetails.test.js on lines 139..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    it("switches tabs to measurement entities", async () => {
        await renderMetricDetails()
        expect(screen.getAllByText(/Metric name/).length).toBe(1)
        fireEvent.click(screen.getByText(/The source/))
        expect(screen.getAllByText(/Attribute status/).length).toBe(1)
    Severity: Major
    Found in components/frontend/src/metric/MetricDetails.test.js and 4 other locations - About 2 hrs to fix
    components/frontend/src/metric/MetricDetails.test.js on lines 105..110
    components/frontend/src/metric/MetricDetails.test.js on lines 112..117
    components/frontend/src/metric/MetricDetails.test.js on lines 126..131
    components/frontend/src/metric/MetricDetails.test.js on lines 139..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    it("switches tabs to the trend graph", async () => {
        await renderMetricDetails()
        expect(screen.getAllByText(/Metric name/).length).toBe(1)
        fireEvent.click(screen.getByText(/Trend graph/))
        expect(screen.getAllByText(/Time/).length).toBe(1)
    Severity: Major
    Found in components/frontend/src/metric/MetricDetails.test.js and 4 other locations - About 2 hrs to fix
    components/frontend/src/metric/MetricDetails.test.js on lines 105..110
    components/frontend/src/metric/MetricDetails.test.js on lines 112..117
    components/frontend/src/metric/MetricDetails.test.js on lines 119..124
    components/frontend/src/metric/MetricDetails.test.js on lines 139..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    it("switches tabs to technical debt", async () => {
        await renderMetricDetails()
        expect(screen.getAllByText(/Metric name/).length).toBe(1)
        fireEvent.click(screen.getByText(/Technical debt/))
        expect(screen.getAllByText(/Technical debt target/).length).toBe(1)
    Severity: Major
    Found in components/frontend/src/metric/MetricDetails.test.js and 4 other locations - About 2 hrs to fix
    components/frontend/src/metric/MetricDetails.test.js on lines 105..110
    components/frontend/src/metric/MetricDetails.test.js on lines 119..124
    components/frontend/src/metric/MetricDetails.test.js on lines 126..131
    components/frontend/src/metric/MetricDetails.test.js on lines 139..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status