Sign upLogin

ICTU/quality-time

View on GitHub
Star
components/frontend/src/report/ReportsOverviewDashboard.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function summarizeReportsOnDate has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function summarizeReportsOnDate(reports, measurements, date, tag, hiddenTags, dataModel) {
Severity: Minor
Found in components/frontend/src/report/ReportsOverviewDashboard.js - About 45 mins to fix

    Function summarizeReportOnDate has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function summarizeReportOnDate(report, measurements, date, hiddenTags, dataModel) {
    Severity: Minor
    Found in components/frontend/src/report/ReportsOverviewDashboard.js - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  Object.entries(metrics).forEach(([metric_uuid, metric]) => {
                if (getMetricTags(metric).indexOf(tag) >= 0) {
                    const status = metricStatusOnDate(metric_uuid, metric, measurements, date, dataModel)
                    summary[STATUS_COLORS[status]] += 1
                }
      Severity: Major
      Found in components/frontend/src/report/ReportsOverviewDashboard.js and 1 other location - About 1 hr to fix
      components/frontend/src/report/ReportDashboard.js on lines 29..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              Object.entries(metrics).forEach(([metric_uuid, metric]) => {
            const status = metricStatusOnDate(metric_uuid, metric, measurements, date, dataModel)
            summary[STATUS_COLORS[status]] += 1
        })
      Severity: Major
      Found in components/frontend/src/report/ReportsOverviewDashboard.js and 1 other location - About 1 hr to fix
      components/frontend/src/report/ReportDashboard.js on lines 19..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

      ReportsOverviewDashboard.propTypes = {
    dates: datesPropType,
    layout: array,
    measurements: measurementsPropType,
    onClickTag: func,
      Severity: Major
      Found in components/frontend/src/report/ReportsOverviewDashboard.js and 7 other locations - About 50 mins to fix
      components/frontend/src/fields/Input.js on lines 45..54
      components/frontend/src/source/Source.js on lines 227..236
      components/frontend/src/source/Sources.js on lines 73..82
      components/frontend/src/subject/SubjectTitle.js on lines 146..155
      components/frontend/src/widgets/Button.js on lines 94..103
      components/frontend/src/widgets/HeaderWithDetails.js on lines 33..42
      components/frontend/src/widgets/TableHeaderCell.js on lines 45..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status