Sign upLogin

ICTU/quality-time

View on GitHub
Star
components/frontend/src/source/SourceParameter.js

Summary

Maintainability
C
1 day
Test Coverage

Function SourceParameter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

export function SourceParameter({
    help,
    help_url,
    index,
    parameter_key,
Severity: Minor
Found in components/frontend/src/source/SourceParameter.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return <StringInput {...parameter_props} />
Severity: Major
Found in components/frontend/src/source/SourceParameter.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return <MultipleChoiceInput {...parameter_props} options={dropdownOptions(parameter_values)} allowAdditions />
    Severity: Major
    Found in components/frontend/src/source/SourceParameter.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return null
      Severity: Major
      Found in components/frontend/src/source/SourceParameter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return <MultipleChoiceInput {...parameter_props} options={dropdownOptions(parameter_values)} />
        Severity: Major
        Found in components/frontend/src/source/SourceParameter.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return <StringInput {...parameter_props} error={warning} />
          Severity: Major
          Found in components/frontend/src/source/SourceParameter.js - About 30 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    {
            key: "metric",
            value: "metric",
            text: "Apply change to metric",
            description: `Change the ${parameter_short_name} of ${source_type_name} sources in this metric that have the same ${parameter_short_name}`,
            Severity: Major
            Found in components/frontend/src/source/SourceParameter.js and 3 other locations - About 1 hr to fix
            components/frontend/src/source/SourceParameter.js on lines 41..47
            components/frontend/src/source/SourceParameter.js on lines 48..54
            components/frontend/src/source/SourceParameter.js on lines 55..61

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    {
            key: "subject",
            value: "subject",
            text: "Apply change to subject",
            description: `Change the ${parameter_short_name} of ${source_type_name} sources in this subject that have the same ${parameter_short_name}`,
            Severity: Major
            Found in components/frontend/src/source/SourceParameter.js and 3 other locations - About 1 hr to fix
            components/frontend/src/source/SourceParameter.js on lines 34..40
            components/frontend/src/source/SourceParameter.js on lines 48..54
            components/frontend/src/source/SourceParameter.js on lines 55..61

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    {
            key: "report",
            value: "report",
            text: "Apply change to report",
            description: `Change the ${parameter_short_name} of ${source_type_name} sources in this report that have the same ${parameter_short_name}`,
            Severity: Major
            Found in components/frontend/src/source/SourceParameter.js and 3 other locations - About 1 hr to fix
            components/frontend/src/source/SourceParameter.js on lines 34..40
            components/frontend/src/source/SourceParameter.js on lines 41..47
            components/frontend/src/source/SourceParameter.js on lines 55..61

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    {
            key: "reports",
            value: "reports",
            text: "Apply change to all reports",
            description: `Change the ${parameter_short_name} of ${source_type_name} sources in all reports that have the same ${parameter_short_name}`,
            Severity: Major
            Found in components/frontend/src/source/SourceParameter.js and 3 other locations - About 1 hr to fix
            components/frontend/src/source/SourceParameter.js on lines 34..40
            components/frontend/src/source/SourceParameter.js on lines 41..47
            components/frontend/src/source/SourceParameter.js on lines 48..54

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status