ICTU/quality-time

View on GitHub
components/frontend/src/source/SourceTypeHeader.test.js

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 7 locations. Consider refactoring.
Open

it("does not point users to specific information in the docs if the information is for other metric types", () => {
    renderSourceTypeHeader({ other_metric: "Generic documentation" })
    expect(screen.queryAllByText(/specific information/).length).toBe(0)
})
Severity: Major
Found in components/frontend/src/source/SourceTypeHeader.test.js and 6 other locations - About 55 mins to fix
components/frontend/src/metric/MetricDebtParameters.test.js on lines 114..117
components/frontend/src/metric/Target.test.js on lines 80..83
components/frontend/src/source/SourceEntity.test.js on lines 37..40
components/frontend/src/source/SourceEntity.test.js on lines 52..55
components/frontend/src/source/SourceParameters.test.js on lines 66..69
components/frontend/src/source/SourceParameters.test.js on lines 76..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

it("shows the supported source versions", () => {
    renderSourceTypeHeader()
    expect(screen.getAllByText(/Supported Source type versions: >=1.0/).length).toBe(1)
})
Severity: Major
Found in components/frontend/src/source/SourceTypeHeader.test.js and 14 other locations - About 35 mins to fix
components/frontend/src/issue/IssuesRows.test.js on lines 39..42
components/frontend/src/measurement/Overrun.test.js on lines 24..27
components/frontend/src/metric/TrendGraph.test.js on lines 24..27
components/frontend/src/report/Report.test.js on lines 80..83
components/frontend/src/report/ReportsOverviewDashboard.test.js on lines 57..60
components/frontend/src/source/Sources.test.js on lines 81..84
components/frontend/src/source/Sources.test.js on lines 97..100
components/frontend/src/subject/SubjectTable.test.js on lines 128..131
components/frontend/src/subject/SubjectTable.test.js on lines 139..142
components/frontend/src/subject/SubjectTable.test.js on lines 150..153
components/frontend/src/subject/SubjectTable.test.js on lines 166..169
components/frontend/src/subject/SubjectTable.test.js on lines 177..180
components/frontend/src/widgets/TableHeaderCell.test.js on lines 26..29
components/frontend/src/widgets/TableHeaderCell.test.js on lines 51..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

it("shows the header", () => {
    renderSourceTypeHeader()
    expect(screen.getAllByText("Source type").length).toBe(1)
})
Severity: Minor
Found in components/frontend/src/source/SourceTypeHeader.test.js and 1 other location - About 35 mins to fix
components/frontend/src/metric/MetricTypeHeader.test.js on lines 17..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status