Sign upLogin

ICTU/quality-time

View on GitHub
Star
components/frontend/src/source/Sources.test.js

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

it("moves a source", async () => {
    fetch_server_api.fetch_server_api = jest.fn().mockResolvedValue({ ok: true })
    renderSources()
    await act(async () => {
        fireEvent.click(screen.getByText(/Move source/))
Severity: Major
Found in components/frontend/src/source/Sources.test.js and 1 other location - About 5 hrs to fix
components/frontend/src/source/Sources.test.js on lines 116..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 140.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

it("copies a source", async () => {
    fetch_server_api.fetch_server_api = jest.fn().mockResolvedValue({ ok: true })
    renderSources()
    await act(async () => {
        fireEvent.click(screen.getByText(/Copy source/))
Severity: Major
Found in components/frontend/src/source/Sources.test.js and 1 other location - About 5 hrs to fix
components/frontend/src/source/Sources.test.js on lines 133..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 140.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

it("doesn't show sources not in the data model", () => {
    renderSources()
    expect(screen.queryAllByDisplayValue(/Source 1/).length).toBe(1)
    expect(screen.queryAllByDisplayValue(/Source with non-existing source type/).length).toBe(0)
})
Severity: Major
Found in components/frontend/src/source/Sources.test.js and 1 other location - About 1 hr to fix
components/frontend/src/subject/SubjectTable.test.js on lines 188..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

it("shows a source", () => {
    renderSources()
    expect(screen.getAllByPlaceholderText(/Source type 1/).length).toBe(1)
})
Severity: Major
Found in components/frontend/src/source/Sources.test.js and 14 other locations - About 35 mins to fix
components/frontend/src/issue/IssuesRows.test.js on lines 39..42
components/frontend/src/measurement/Overrun.test.js on lines 24..27
components/frontend/src/metric/TrendGraph.test.js on lines 24..27
components/frontend/src/report/Report.test.js on lines 80..83
components/frontend/src/report/ReportsOverviewDashboard.test.js on lines 57..60
components/frontend/src/source/SourceTypeHeader.test.js on lines 41..44
components/frontend/src/source/Sources.test.js on lines 97..100
components/frontend/src/subject/SubjectTable.test.js on lines 128..131
components/frontend/src/subject/SubjectTable.test.js on lines 139..142
components/frontend/src/subject/SubjectTable.test.js on lines 150..153
components/frontend/src/subject/SubjectTable.test.js on lines 166..169
components/frontend/src/subject/SubjectTable.test.js on lines 177..180
components/frontend/src/widgets/TableHeaderCell.test.js on lines 26..29
components/frontend/src/widgets/TableHeaderCell.test.js on lines 51..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

it("shows errored sources", () => {
    renderSources()
    expect(screen.getAllByText(/Connection error/).length).toBe(1)
})
Severity: Major
Found in components/frontend/src/source/Sources.test.js and 14 other locations - About 35 mins to fix
components/frontend/src/issue/IssuesRows.test.js on lines 39..42
components/frontend/src/measurement/Overrun.test.js on lines 24..27
components/frontend/src/metric/TrendGraph.test.js on lines 24..27
components/frontend/src/report/Report.test.js on lines 80..83
components/frontend/src/report/ReportsOverviewDashboard.test.js on lines 57..60
components/frontend/src/source/SourceTypeHeader.test.js on lines 41..44
components/frontend/src/source/Sources.test.js on lines 81..84
components/frontend/src/subject/SubjectTable.test.js on lines 128..131
components/frontend/src/subject/SubjectTable.test.js on lines 139..142
components/frontend/src/subject/SubjectTable.test.js on lines 150..153
components/frontend/src/subject/SubjectTable.test.js on lines 166..169
components/frontend/src/subject/SubjectTable.test.js on lines 177..180
components/frontend/src/widgets/TableHeaderCell.test.js on lines 26..29
components/frontend/src/widgets/TableHeaderCell.test.js on lines 51..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status