IHTSDO/component-identifier-service

View on GitHub
blogic/BulkJobDataManager.js

Summary

Maintainability
A
1 hr
Test Coverage

Function getJobRecords has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getJobRecords(jobId, callback) {

    bulkJob.findById({id: parseInt(jobId)}, function (err, jobRecord) {
        if (err) {
            callback(err, null);
Severity: Minor
Found in blogic/BulkJobDataManager.js - About 1 hr to fix

    Expected '===' and instead saw '=='.
    Open

                        if (!schemeIds || schemeIds.length == 0) {
    Severity: Minor
    Found in blogic/BulkJobDataManager.js by eslint

    Require === and !== (eqeqeq)

    It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

    The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

    • [] == false
    • [] == ![]
    • 3 == "03"

    If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

    Rule Details

    This rule is aimed at eliminating the type-unsafe equality operators.

    Examples of incorrect code for this rule:

    /*eslint eqeqeq: "error"*/
    
    if (x == 42) { }
    
    if ("" == text) { }
    
    if (obj.getStuff() != undefined) { }

    The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

    Options

    always

    The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

    Examples of incorrect code for the "always" option:

    /*eslint eqeqeq: ["error", "always"]*/
    
    a == b
    foo == true
    bananas != 1
    value == undefined
    typeof foo == 'undefined'
    'hello' != 'world'
    0 == 0
    true == true
    foo == null

    Examples of correct code for the "always" option:

    /*eslint eqeqeq: ["error", "always"]*/
    
    a === b
    foo === true
    bananas !== 1
    value === undefined
    typeof foo === 'undefined'
    'hello' !== 'world'
    0 === 0
    true === true
    foo === null

    This rule optionally takes a second argument, which should be an object with the following supported properties:

    • "null": Customize how this rule treats null literals. Possible values:
      • always (default) - Always use === or !==.
      • never - Never use === or !== with null.
      • ignore - Do not apply this rule to null.

    smart

    The "smart" option enforces the use of === and !== except for these cases:

    • Comparing two literal values
    • Evaluating the value of typeof
    • Comparing against null

    Examples of incorrect code for the "smart" option:

    /*eslint eqeqeq: ["error", "smart"]*/
    
    // comparing two variables requires ===
    a == b
    
    // only one side is a literal
    foo == true
    bananas != 1
    
    // comparing to undefined requires ===
    value == undefined

    Examples of correct code for the "smart" option:

    /*eslint eqeqeq: ["error", "smart"]*/
    
    typeof foo == 'undefined'
    'hello' != 'world'
    0 == 0
    true == true
    foo == null

    allow-null

    Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

    ["error", "always", {"null": "ignore"}]

    When Not To Use It

    If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

    Missing radix parameter.
    Open

        bulkJob.findById({id: parseInt(jobId)}, function (err, bulkJobRecord) {
    Severity: Minor
    Found in blogic/BulkJobDataManager.js by eslint

    Require Radix Parameter (radix)

    When using the parseInt() function it is common to omit the second argument, the radix, and let the function try to determine from the first argument what type of number it is. By default, parseInt() will autodetect decimal and hexadecimal (via 0x prefix). Prior to ECMAScript 5, parseInt() also autodetected octal literals, which caused problems because many developers assumed a leading 0 would be ignored.

    This confusion led to the suggestion that you always use the radix parameter to parseInt() to eliminate unintended consequences. So instead of doing this:

    var num = parseInt("071");      // 57

    Do this:

    var num = parseInt("071", 10);  // 71

    ECMAScript 5 changed the behavior of parseInt() so that it no longer autodetects octal literals and instead treats them as decimal literals. However, the differences between hexadecimal and decimal interpretation of the first parameter causes many developers to continue using the radix parameter to ensure the string is interpreted in the intended way.

    On the other hand, if the code is targeting only ES5-compliant environments passing the radix 10 may be redundant. In such a case you might want to disallow using such a radix.

    Rule Details

    This rule is aimed at preventing the unintended conversion of a string to a number of a different base than intended or at preventing the redundant 10 radix if targeting modern environments only.

    Options

    There are two options for this rule:

    • "always" enforces providing a radix (default)
    • "as-needed" disallows providing the 10 radix

    always

    Examples of incorrect code for the default "always" option:

    /*eslint radix: "error"*/
    
    var num = parseInt("071");
    
    var num = parseInt(someValue);
    
    var num = parseInt("071", "abc");
    
    var num = parseInt();

    Examples of correct code for the default "always" option:

    /*eslint radix: "error"*/
    
    var num = parseInt("071", 10);
    
    var num = parseInt("071", 8);
    
    var num = parseFloat(someValue);

    as-needed

    Examples of incorrect code for the "as-needed" option:

    /*eslint radix: ["error", "as-needed"]*/
    
    var num = parseInt("071", 10);
    
    var num = parseInt("071", "abc");
    
    var num = parseInt();

    Examples of correct code for the "as-needed" option:

    /*eslint radix: ["error", "as-needed"]*/
    
    var num = parseInt("071");
    
    var num = parseInt("071", 8);
    
    var num = parseFloat(someValue);

    When Not To Use It

    If you don't want to enforce either presence or omission of the 10 radix value you can turn this rule off.

    Further Reading

    Expected '===' and instead saw '=='.
    Open

                if (jobRecord.request.model == job.MODELS.SchemeId) {
    Severity: Minor
    Found in blogic/BulkJobDataManager.js by eslint

    Require === and !== (eqeqeq)

    It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

    The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

    • [] == false
    • [] == ![]
    • 3 == "03"

    If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

    Rule Details

    This rule is aimed at eliminating the type-unsafe equality operators.

    Examples of incorrect code for this rule:

    /*eslint eqeqeq: "error"*/
    
    if (x == 42) { }
    
    if ("" == text) { }
    
    if (obj.getStuff() != undefined) { }

    The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

    Options

    always

    The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

    Examples of incorrect code for the "always" option:

    /*eslint eqeqeq: ["error", "always"]*/
    
    a == b
    foo == true
    bananas != 1
    value == undefined
    typeof foo == 'undefined'
    'hello' != 'world'
    0 == 0
    true == true
    foo == null

    Examples of correct code for the "always" option:

    /*eslint eqeqeq: ["error", "always"]*/
    
    a === b
    foo === true
    bananas !== 1
    value === undefined
    typeof foo === 'undefined'
    'hello' !== 'world'
    0 === 0
    true === true
    foo === null

    This rule optionally takes a second argument, which should be an object with the following supported properties:

    • "null": Customize how this rule treats null literals. Possible values:
      • always (default) - Always use === or !==.
      • never - Never use === or !== with null.
      • ignore - Do not apply this rule to null.

    smart

    The "smart" option enforces the use of === and !== except for these cases:

    • Comparing two literal values
    • Evaluating the value of typeof
    • Comparing against null

    Examples of incorrect code for the "smart" option:

    /*eslint eqeqeq: ["error", "smart"]*/
    
    // comparing two variables requires ===
    a == b
    
    // only one side is a literal
    foo == true
    bananas != 1
    
    // comparing to undefined requires ===
    value == undefined

    Examples of correct code for the "smart" option:

    /*eslint eqeqeq: ["error", "smart"]*/
    
    typeof foo == 'undefined'
    'hello' != 'world'
    0 == 0
    true == true
    foo == null

    allow-null

    Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

    ["error", "always", {"null": "ignore"}]

    When Not To Use It

    If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

    Missing radix parameter.
    Open

                    schemeid.findByJobId({jobId: parseInt(jobId)}, function (err, schemeIds) {
    Severity: Minor
    Found in blogic/BulkJobDataManager.js by eslint

    Require Radix Parameter (radix)

    When using the parseInt() function it is common to omit the second argument, the radix, and let the function try to determine from the first argument what type of number it is. By default, parseInt() will autodetect decimal and hexadecimal (via 0x prefix). Prior to ECMAScript 5, parseInt() also autodetected octal literals, which caused problems because many developers assumed a leading 0 would be ignored.

    This confusion led to the suggestion that you always use the radix parameter to parseInt() to eliminate unintended consequences. So instead of doing this:

    var num = parseInt("071");      // 57

    Do this:

    var num = parseInt("071", 10);  // 71

    ECMAScript 5 changed the behavior of parseInt() so that it no longer autodetects octal literals and instead treats them as decimal literals. However, the differences between hexadecimal and decimal interpretation of the first parameter causes many developers to continue using the radix parameter to ensure the string is interpreted in the intended way.

    On the other hand, if the code is targeting only ES5-compliant environments passing the radix 10 may be redundant. In such a case you might want to disallow using such a radix.

    Rule Details

    This rule is aimed at preventing the unintended conversion of a string to a number of a different base than intended or at preventing the redundant 10 radix if targeting modern environments only.

    Options

    There are two options for this rule:

    • "always" enforces providing a radix (default)
    • "as-needed" disallows providing the 10 radix

    always

    Examples of incorrect code for the default "always" option:

    /*eslint radix: "error"*/
    
    var num = parseInt("071");
    
    var num = parseInt(someValue);
    
    var num = parseInt("071", "abc");
    
    var num = parseInt();

    Examples of correct code for the default "always" option:

    /*eslint radix: "error"*/
    
    var num = parseInt("071", 10);
    
    var num = parseInt("071", 8);
    
    var num = parseFloat(someValue);

    as-needed

    Examples of incorrect code for the "as-needed" option:

    /*eslint radix: ["error", "as-needed"]*/
    
    var num = parseInt("071", 10);
    
    var num = parseInt("071", "abc");
    
    var num = parseInt();

    Examples of correct code for the "as-needed" option:

    /*eslint radix: ["error", "as-needed"]*/
    
    var num = parseInt("071");
    
    var num = parseInt("071", 8);
    
    var num = parseFloat(someValue);

    When Not To Use It

    If you don't want to enforce either presence or omission of the 10 radix value you can turn this rule off.

    Further Reading

    Missing radix parameter.
    Open

                        sctid.findByJobId({jobId: parseInt(jobId)}, function (err, sctids) {
    Severity: Minor
    Found in blogic/BulkJobDataManager.js by eslint

    Require Radix Parameter (radix)

    When using the parseInt() function it is common to omit the second argument, the radix, and let the function try to determine from the first argument what type of number it is. By default, parseInt() will autodetect decimal and hexadecimal (via 0x prefix). Prior to ECMAScript 5, parseInt() also autodetected octal literals, which caused problems because many developers assumed a leading 0 would be ignored.

    This confusion led to the suggestion that you always use the radix parameter to parseInt() to eliminate unintended consequences. So instead of doing this:

    var num = parseInt("071");      // 57

    Do this:

    var num = parseInt("071", 10);  // 71

    ECMAScript 5 changed the behavior of parseInt() so that it no longer autodetects octal literals and instead treats them as decimal literals. However, the differences between hexadecimal and decimal interpretation of the first parameter causes many developers to continue using the radix parameter to ensure the string is interpreted in the intended way.

    On the other hand, if the code is targeting only ES5-compliant environments passing the radix 10 may be redundant. In such a case you might want to disallow using such a radix.

    Rule Details

    This rule is aimed at preventing the unintended conversion of a string to a number of a different base than intended or at preventing the redundant 10 radix if targeting modern environments only.

    Options

    There are two options for this rule:

    • "always" enforces providing a radix (default)
    • "as-needed" disallows providing the 10 radix

    always

    Examples of incorrect code for the default "always" option:

    /*eslint radix: "error"*/
    
    var num = parseInt("071");
    
    var num = parseInt(someValue);
    
    var num = parseInt("071", "abc");
    
    var num = parseInt();

    Examples of correct code for the default "always" option:

    /*eslint radix: "error"*/
    
    var num = parseInt("071", 10);
    
    var num = parseInt("071", 8);
    
    var num = parseFloat(someValue);

    as-needed

    Examples of incorrect code for the "as-needed" option:

    /*eslint radix: ["error", "as-needed"]*/
    
    var num = parseInt("071", 10);
    
    var num = parseInt("071", "abc");
    
    var num = parseInt();

    Examples of correct code for the "as-needed" option:

    /*eslint radix: ["error", "as-needed"]*/
    
    var num = parseInt("071");
    
    var num = parseInt("071", 8);
    
    var num = parseFloat(someValue);

    When Not To Use It

    If you don't want to enforce either presence or omission of the 10 radix value you can turn this rule off.

    Further Reading

    Expected '===' and instead saw '=='.
    Open

                            if (!sctids || sctids.length == 0) {
    Severity: Minor
    Found in blogic/BulkJobDataManager.js by eslint

    Require === and !== (eqeqeq)

    It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

    The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

    • [] == false
    • [] == ![]
    • 3 == "03"

    If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

    Rule Details

    This rule is aimed at eliminating the type-unsafe equality operators.

    Examples of incorrect code for this rule:

    /*eslint eqeqeq: "error"*/
    
    if (x == 42) { }
    
    if ("" == text) { }
    
    if (obj.getStuff() != undefined) { }

    The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

    Options

    always

    The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

    Examples of incorrect code for the "always" option:

    /*eslint eqeqeq: ["error", "always"]*/
    
    a == b
    foo == true
    bananas != 1
    value == undefined
    typeof foo == 'undefined'
    'hello' != 'world'
    0 == 0
    true == true
    foo == null

    Examples of correct code for the "always" option:

    /*eslint eqeqeq: ["error", "always"]*/
    
    a === b
    foo === true
    bananas !== 1
    value === undefined
    typeof foo === 'undefined'
    'hello' !== 'world'
    0 === 0
    true === true
    foo === null

    This rule optionally takes a second argument, which should be an object with the following supported properties:

    • "null": Customize how this rule treats null literals. Possible values:
      • always (default) - Always use === or !==.
      • never - Never use === or !== with null.
      • ignore - Do not apply this rule to null.

    smart

    The "smart" option enforces the use of === and !== except for these cases:

    • Comparing two literal values
    • Evaluating the value of typeof
    • Comparing against null

    Examples of incorrect code for the "smart" option:

    /*eslint eqeqeq: ["error", "smart"]*/
    
    // comparing two variables requires ===
    a == b
    
    // only one side is a literal
    foo == true
    bananas != 1
    
    // comparing to undefined requires ===
    value == undefined

    Examples of correct code for the "smart" option:

    /*eslint eqeqeq: ["error", "smart"]*/
    
    typeof foo == 'undefined'
    'hello' != 'world'
    0 == 0
    true == true
    foo == null

    allow-null

    Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

    ["error", "always", {"null": "ignore"}]

    When Not To Use It

    If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

    Missing radix parameter.
    Open

        bulkJob.findById({id: parseInt(jobId)}, function (err, jobRecord) {
    Severity: Minor
    Found in blogic/BulkJobDataManager.js by eslint

    Require Radix Parameter (radix)

    When using the parseInt() function it is common to omit the second argument, the radix, and let the function try to determine from the first argument what type of number it is. By default, parseInt() will autodetect decimal and hexadecimal (via 0x prefix). Prior to ECMAScript 5, parseInt() also autodetected octal literals, which caused problems because many developers assumed a leading 0 would be ignored.

    This confusion led to the suggestion that you always use the radix parameter to parseInt() to eliminate unintended consequences. So instead of doing this:

    var num = parseInt("071");      // 57

    Do this:

    var num = parseInt("071", 10);  // 71

    ECMAScript 5 changed the behavior of parseInt() so that it no longer autodetects octal literals and instead treats them as decimal literals. However, the differences between hexadecimal and decimal interpretation of the first parameter causes many developers to continue using the radix parameter to ensure the string is interpreted in the intended way.

    On the other hand, if the code is targeting only ES5-compliant environments passing the radix 10 may be redundant. In such a case you might want to disallow using such a radix.

    Rule Details

    This rule is aimed at preventing the unintended conversion of a string to a number of a different base than intended or at preventing the redundant 10 radix if targeting modern environments only.

    Options

    There are two options for this rule:

    • "always" enforces providing a radix (default)
    • "as-needed" disallows providing the 10 radix

    always

    Examples of incorrect code for the default "always" option:

    /*eslint radix: "error"*/
    
    var num = parseInt("071");
    
    var num = parseInt(someValue);
    
    var num = parseInt("071", "abc");
    
    var num = parseInt();

    Examples of correct code for the default "always" option:

    /*eslint radix: "error"*/
    
    var num = parseInt("071", 10);
    
    var num = parseInt("071", 8);
    
    var num = parseFloat(someValue);

    as-needed

    Examples of incorrect code for the "as-needed" option:

    /*eslint radix: ["error", "as-needed"]*/
    
    var num = parseInt("071", 10);
    
    var num = parseInt("071", "abc");
    
    var num = parseInt();

    Examples of correct code for the "as-needed" option:

    /*eslint radix: ["error", "as-needed"]*/
    
    var num = parseInt("071");
    
    var num = parseInt("071", 8);
    
    var num = parseFloat(someValue);

    When Not To Use It

    If you don't want to enforce either presence or omission of the 10 radix value you can turn this rule off.

    Further Reading

    There are no issues that match your filters.

    Category
    Status