IHTSDO/component-identifier-service

View on GitHub
model/job.js

Summary

Maintainability
D
2 days
Test Coverage

Function findFieldSelect has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

job.findFieldSelect=function(query, fields,limit, skip,orderBy, callback){
    db.getDB(function (err,connection)
    {
        if (err) throw err;
        if (!query){
Severity: Minor
Found in model/job.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findFieldSelect has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

job.findFieldSelect=function(query, fields,limit, skip,orderBy, callback){
    db.getDB(function (err,connection)
    {
        if (err) throw err;
        if (!query){
Severity: Major
Found in model/job.js - About 3 hrs to fix

    Function has a complexity of 17.
    Open

        db.getDB(function (err,connection)
    Severity: Minor
    Found in model/job.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function find has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    job.find=function(query, limit, skip, callback){
        db.getDB(function (err,connection)
        {
            if (err) throw err;
            if (!query){
    Severity: Minor
    Found in model/job.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function find has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    job.find=function(query, limit, skip, callback){
        db.getDB(function (err,connection)
        {
            if (err) throw err;
            if (!query){
    Severity: Minor
    Found in model/job.js - About 1 hr to fix

      Function has a complexity of 8.
      Open

          db.getDB(function (err,connection)
      Severity: Minor
      Found in model/job.js by eslint

      Limit Cyclomatic Complexity (complexity)

      Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

      function a(x) {
          if (true) {
              return x; // 1st path
          } else if (false) {
              return x+1; // 2nd path
          } else {
              return 4; // 3rd path
          }
      }

      Rule Details

      This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

      Examples of incorrect code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else if (false) {
              return x+1;
          } else {
              return 4; // 3rd path
          }
      }

      Examples of correct code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else {
              return 4;
          }
      }

      Options

      Optionally, you may specify a max object property:

      "complexity": ["error", 2]

      is equivalent to

      "complexity": ["error", { "max": 2 }]

      Deprecated: the object property maximum is deprecated. Please use the property max instead.

      When Not To Use It

      If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

      Further Reading

      Related Rules

      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md)
      • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

      Function has too many statements (32). Maximum allowed is 30.
      Open

          db.getDB(function (err,connection)
      Severity: Minor
      Found in model/job.js by eslint

      enforce a maximum number of statements allowed in function blocks (max-statements)

      The max-statements rule allows you to specify the maximum number of statements allowed in a function.

      function foo() {
        var bar = 1; // one statement
        var baz = 2; // two statements
        var qux = 3; // three statements
      }

      Rule Details

      This rule enforces a maximum number of statements allowed in function blocks.

      Options

      This rule has a number or object option:

      • "max" (default 10) enforces a maximum number of statements allows in function blocks

      Deprecated: The object property maximum is deprecated; please use the object property max instead.

      This rule has an object option:

      • "ignoreTopLevelFunctions": true ignores top-level functions

      max

      Examples of incorrect code for this rule with the default { "max": 10 } option:

      /*eslint max-statements: ["error", 10]*/
      /*eslint-env es6*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
      
        var foo11 = 11; // Too many.
      }
      
      let foo = () => {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
      
        var foo11 = 11; // Too many.
      };

      Examples of correct code for this rule with the default { "max": 10 } option:

      /*eslint max-statements: ["error", 10]*/
      /*eslint-env es6*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        return function () {
      
          // The number of statements in the inner function does not count toward the
          // statement maximum.
      
          return 42;
        };
      }
      
      let foo = () => {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        return function () {
      
          // The number of statements in the inner function does not count toward the
          // statement maximum.
      
          return 42;
        };
      }

      ignoreTopLevelFunctions

      Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

      /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        var foo11 = 11;
      }

      Related Rules

      • [complexity](complexity.md)
      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

      Function has a complexity of 7.
      Open

              connection.query(sql, function(error, rows)
      Severity: Minor
      Found in model/job.js by eslint

      Limit Cyclomatic Complexity (complexity)

      Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

      function a(x) {
          if (true) {
              return x; // 1st path
          } else if (false) {
              return x+1; // 2nd path
          } else {
              return 4; // 3rd path
          }
      }

      Rule Details

      This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

      Examples of incorrect code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else if (false) {
              return x+1;
          } else {
              return 4; // 3rd path
          }
      }

      Examples of correct code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else {
              return 4;
          }
      }

      Options

      Optionally, you may specify a max object property:

      "complexity": ["error", 2]

      is equivalent to

      "complexity": ["error", { "max": 2 }]

      Deprecated: the object property maximum is deprecated. Please use the property max instead.

      When Not To Use It

      If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

      Further Reading

      Related Rules

      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md)
      • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

      Function has a complexity of 7.
      Open

              connection.query(sql, function(error, rows)
      Severity: Minor
      Found in model/job.js by eslint

      Limit Cyclomatic Complexity (complexity)

      Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

      function a(x) {
          if (true) {
              return x; // 1st path
          } else if (false) {
              return x+1; // 2nd path
          } else {
              return 4; // 3rd path
          }
      }

      Rule Details

      This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

      Examples of incorrect code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else if (false) {
              return x+1;
          } else {
              return 4; // 3rd path
          }
      }

      Examples of correct code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/
      
      function a(x) {
          if (true) {
              return x;
          } else {
              return 4;
          }
      }

      Options

      Optionally, you may specify a max object property:

      "complexity": ["error", 2]

      is equivalent to

      "complexity": ["error", { "max": 2 }]

      Deprecated: the object property maximum is deprecated. Please use the property max instead.

      When Not To Use It

      If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

      Further Reading

      Related Rules

      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md)
      • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

      Function save has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      job.save=function(jobRecord,callback){
      
          db.getDB(function (err,connection)
          {
              if (err) throw err;
      Severity: Minor
      Found in model/job.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      job.save=function(jobRecord,callback){
      
          db.getDB(function (err,connection)
          {
              if (err) throw err;
      Severity: Minor
      Found in model/job.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (limit && limit > 0 && limit < cont) {
                                        break;
                                    }
        Severity: Major
        Found in model/job.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (limit && limit > 0 && limit < cont) {
                                          break;
                                      }
          Severity: Major
          Found in model/job.js - About 45 mins to fix

            Function findFieldSelect has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            job.findFieldSelect=function(query, fields,limit, skip,orderBy, callback){
            Severity: Minor
            Found in model/job.js - About 45 mins to fix

              Expected return with your callback function.
              Open

                                  callback(null, rows[0]);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected return with your callback function.
              Open

                                  callback(null, jobRecord);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected return with your callback function.
              Open

                              callback(error, null);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected return with your callback function.
              Open

                                  callback(null, null);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected '!==' and instead saw '!='.
              Open

                      if (dataOrder!=""){
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected return with your callback function.
              Open

                          callback(null, jobRecord);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected '===' and instead saw '=='.
              Open

                              if ((!skip || skip==0)) {
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected return with your callback function.
              Open

                                  callback(null, rows);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected '!==' and instead saw '!='.
              Open

                      if (swhere!=""){
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              'field' is already defined.
              Open

                          for (var field in fields) {
              Severity: Minor
              Found in model/job.js by eslint

              disallow variable redeclaration (no-redeclare)

              In JavaScript, it's possible to redeclare the same variable name using var. This can lead to confusion as to where the variable is actually declared and initialized.

              Rule Details

              This rule is aimed at eliminating variables that have multiple declarations in the same scope.

              Examples of incorrect code for this rule:

              /*eslint no-redeclare: "error"*/
              
              var a = 3;
              var a = 10;

              Examples of correct code for this rule:

              /*eslint no-redeclare: "error"*/
              
              var a = 3;
              // ...
              a = 10;

              Options

              This rule takes one optional argument, an object with a boolean property "builtinGlobals". It defaults to false. If set to true, this rule also checks redeclaration of built-in globals, such as Object, Array, Number...

              builtinGlobals

              Examples of incorrect code for the { "builtinGlobals": true } option:

              /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
              
              var Object = 0;

              Examples of incorrect code for the { "builtinGlobals": true } option and the browser environment:

              /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
              /*eslint-env browser*/
              
              var top = 0;

              The browser environment has many built-in global variables (for example, top). Some of built-in global variables cannot be redeclared. Source: http://eslint.org/docs/rules/

              'field' is already defined.
              Open

                          for (var field in orderBy) {
              Severity: Minor
              Found in model/job.js by eslint

              disallow variable redeclaration (no-redeclare)

              In JavaScript, it's possible to redeclare the same variable name using var. This can lead to confusion as to where the variable is actually declared and initialized.

              Rule Details

              This rule is aimed at eliminating variables that have multiple declarations in the same scope.

              Examples of incorrect code for this rule:

              /*eslint no-redeclare: "error"*/
              
              var a = 3;
              var a = 10;

              Examples of correct code for this rule:

              /*eslint no-redeclare: "error"*/
              
              var a = 3;
              // ...
              a = 10;

              Options

              This rule takes one optional argument, an object with a boolean property "builtinGlobals". It defaults to false. If set to true, this rule also checks redeclaration of built-in globals, such as Object, Array, Number...

              builtinGlobals

              Examples of incorrect code for the { "builtinGlobals": true } option:

              /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
              
              var Object = 0;

              Examples of incorrect code for the { "builtinGlobals": true } option and the browser environment:

              /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
              /*eslint-env browser*/
              
              var top = 0;

              The browser environment has many built-in global variables (for example, top). Some of built-in global variables cannot be redeclared. Source: http://eslint.org/docs/rules/

              Expected '!==' and instead saw '!='.
              Open

                      if (select!=""){
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected return with your callback function.
              Open

                              callback (error,null);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected '===' and instead saw '=='.
              Open

                              if ((!skip || skip==0)) {
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected '!==' and instead saw '!='.
              Open

                      if (swhere!=""){
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected return with your callback function.
              Open

                                  callback(null, newRows);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected '!==' and instead saw '!='.
              Open

                      if (supdate!="") {
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected return with your callback function.
              Open

                                  callback(null, rows);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected return with your callback function.
              Open

                              callback(null, jobRecord);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected '===' and instead saw '=='.
              Open

                      if (limit && limit>0 && (!skip || skip==0)) {
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected '===' and instead saw '=='.
              Open

                      if (limit && limit>0 && (!skip || skip==0)) {
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected return with your callback function.
              Open

                              callback(error, null);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected return with your callback function.
              Open

                                  callback(null, newRows);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected '===' and instead saw '=='.
              Open

                                  if (orderBy[field]=="D"){
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected '!==' and instead saw '!='.
              Open

                              if (field!="id") {
              Severity: Minor
              Found in model/job.js by eslint

              Require === and !== (eqeqeq)

              It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

              The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

              • [] == false
              • [] == ![]
              • 3 == "03"

              If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

              Rule Details

              This rule is aimed at eliminating the type-unsafe equality operators.

              Examples of incorrect code for this rule:

              /*eslint eqeqeq: "error"*/
              
              if (x == 42) { }
              
              if ("" == text) { }
              
              if (obj.getStuff() != undefined) { }

              The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

              Options

              always

              The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

              Examples of incorrect code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a == b
              foo == true
              bananas != 1
              value == undefined
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              Examples of correct code for the "always" option:

              /*eslint eqeqeq: ["error", "always"]*/
              
              a === b
              foo === true
              bananas !== 1
              value === undefined
              typeof foo === 'undefined'
              'hello' !== 'world'
              0 === 0
              true === true
              foo === null

              This rule optionally takes a second argument, which should be an object with the following supported properties:

              • "null": Customize how this rule treats null literals. Possible values:
                • always (default) - Always use === or !==.
                • never - Never use === or !== with null.
                • ignore - Do not apply this rule to null.

              smart

              The "smart" option enforces the use of === and !== except for these cases:

              • Comparing two literal values
              • Evaluating the value of typeof
              • Comparing against null

              Examples of incorrect code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              // comparing two variables requires ===
              a == b
              
              // only one side is a literal
              foo == true
              bananas != 1
              
              // comparing to undefined requires ===
              value == undefined

              Examples of correct code for the "smart" option:

              /*eslint eqeqeq: ["error", "smart"]*/
              
              typeof foo == 'undefined'
              'hello' != 'world'
              0 == 0
              true == true
              foo == null

              allow-null

              Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

              ["error", "always", {"null": "ignore"}]

              When Not To Use It

              If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

              Expected return with your callback function.
              Open

                              callback(error, null);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              Expected return with your callback function.
              Open

                                  callback (error,null);
              Severity: Minor
              Found in model/job.js by eslint

              Enforce Return After Callback (callback-return)

              The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

              function doSomething(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

              Rule Details

              This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

              Options

              The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

              Default callback names

              Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err);
                  }
                  callback();
              }

              Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      return callback(err);
                  }
                  callback();
              }

              Supplied callback names

              Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      send.error(err);
                  }
                  send.success();
              }

              Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

              /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
              
              function foo(err, done) {
                  if (err) {
                      return done(err);
                  }
                  done();
              }
              
              function bar(err, send) {
                  if (err) {
                      return send.error(err);
                  }
                  send.success();
              }

              Known Limitations

              Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

              • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
              • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

              Passing the callback by reference

              The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      setTimeout(callback, 0); // this is bad, but WILL NOT warn
                  }
                  callback();
              }

              Triggering the callback within a nested function

              The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

              Example of a false negative when this rule reports correct code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      process.nextTick(function() {
                          return callback(); // this is bad, but WILL NOT warn
                      });
                  }
                  callback();
              }

              If/else statements

              The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

              Example of a false positive when this rule reports incorrect code:

              /*eslint callback-return: "error"*/
              
              function foo(err, callback) {
                  if (err) {
                      callback(err); // this is fine, but WILL warn
                  } else {
                      callback();    // this is fine, but WILL warn
                  }
              }

              When Not To Use It

              There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

              Further Reading

              Related Rules

              There are no issues that match your filters.

              Category
              Status