Sign upLogin

IL2HorusTeam/il2fb-difficulty

View on GitHub
Star

Showing 3 of 9 total issues

File constants.py has 353 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-

from candv import (
    Constants, SimpleConstant, Values, VerboseConstant, VerboseValueConstant,
)
Severity: Minor
Found in il2fb/config/difficulty/constants.py - About 4 hrs to fix

    Function autocorrect_difficulty has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def autocorrect_difficulty(difficulty):
    validate_difficulty(difficulty)

    affected_parameters = {}
    actual_rules = get_actual_rules(difficulty)
    Severity: Minor
    Found in il2fb/config/difficulty/__init__.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _process_side_effects has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def _process_side_effects(self, difficulty, side_effects):
        if RULE_TYPES.TURNS_ON in side_effects:
            for parameter in side_effects[RULE_TYPES.TURNS_ON]:
                difficulty = toggle_parameter_raw(difficulty, parameter, True)
    Severity: Minor
    Found in il2fb/config/difficulty/__init__.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language