Sign upLogin

Identified/sensei-rb

View on GitHub
Star

Showing 2 of 4 total issues

Class Client has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client
    cattr_accessor :sensei_hosts, :sensei_port, :http_kafka_port, :uid_key, :http_kafka_hosts, :fake_update
    attr_accessor :search_timeout

    DATA_TRANSACTION_KEY = "sensei_client_data_transaction"
Severity: Minor
Found in lib/sensei/client.rb - About 3 hrs to fix

    Method to_h has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_h
      if self.not_query?
        raise Exception, "Error: independent boolean NOT query not allowed."
      end
    Severity: Minor
    Found in lib/sensei/query.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language