Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star
htdocs/include/linkexternal.js

Summary

Maintainability
A
35 mins
Test Coverage

Function icms_ExternalLinks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function icms_ExternalLinks() {  
    if (!document.getElementsByTagName) return;  

    var anchors = document.getElementsByTagName("a");  
    for (var i=0; i<anchors.length; i++) {
Severity: Minor
Found in htdocs/include/linkexternal.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Unexpected trailing spaces found.
Open

        var relvalue = anchor.getAttribute("rel");
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

        if (anchor.getAttribute("href")) {
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

    var anchors = document.getElementsByTagName("a");
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

    if (!document.getElementsByTagName) return;
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

function icms_ExternalLinks() {
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

            var relvalue = anchor.getAttribute("rel");
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

        }
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

    for (var i=0; i<anchors.length; i++) {
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

            var external = /external/;
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

        var anchor = anchors[i];
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

            }
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

Unexpected trailing spaces found.
Open

    }
Severity: Minor
Found in htdocs/include/linkexternal.js by editorconfig

There are no issues that match your filters.

Category
Status