Sign upLogin

IndyIndyIndy/youku

View on GitHub
Star

Showing 5 of 5 total issues

Method getOEmbedData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function getOEmbedData($mediaId)
    {
        $html = GeneralUtility::getUrl(
            $this->getOEmbedUrl($mediaId)
        );
Severity: Minor
Found in Classes/Resource/OnlineMedia/Helpers/YoukuHelper.php - About 1 hr to fix

    Function collectIframeAttributes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function collectIframeAttributes($width, $height, array $options)
    {
        $attributes = ['allowfullscreen'];
        if (isset($options['additionalAttributes']) && is_array($options['additionalAttributes'])) {
            $attributes[] = GeneralUtility::implodeAttributes($options['additionalAttributes'], true, true);
    Severity: Minor
    Found in Classes/Resource/Rendering/YoukuRenderer.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method render has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function render(FileInterface $file, $width, $height, array $options = [], $usedPathsRelativeToCurrentScript = false)
    Severity: Minor
    Found in Classes/Resource/Rendering/YoukuRenderer.php - About 35 mins to fix

      Function collectOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function collectOptions(array $options, FileInterface $file)
    {
        if (!isset($options['autoplay']) && $file instanceof FileReference) {
            $autoplay = $file->getProperty('autoplay');
            if ($autoplay !== null) {
      Severity: Minor
      Found in Classes/Resource/Rendering/YoukuRenderer.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getOnlineMediaHelper has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getOnlineMediaHelper(FileInterface $file)
    {
        if ($this->onlineMediaHelper === null) {
            $orgFile = $file;
            if ($orgFile instanceof FileReference) {
      Severity: Minor
      Found in Classes/Resource/Rendering/YoukuRenderer.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language