IntegerMan/angularIF

View on GitHub
src/assets/primeng/components/fileupload/fileupload.js

Summary

Maintainability
F
6 days
Test Coverage

Function FileUpload has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

var FileUpload = (function () {
    function FileUpload(domHandler, sanitizer, zone) {
        this.domHandler = domHandler;
        this.sanitizer = sanitizer;
        this.zone = zone;
Severity: Minor
Found in src/assets/primeng/components/fileupload/fileupload.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function FileUpload has 260 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var FileUpload = (function () {
    function FileUpload(domHandler, sanitizer, zone) {
        this.domHandler = domHandler;
        this.sanitizer = sanitizer;
        this.zone = zone;
Severity: Major
Found in src/assets/primeng/components/fileupload/fileupload.js - About 1 day to fix

    File fileupload.js has 451 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    "use strict";
    var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
        var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
        if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
        else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
    Severity: Minor
    Found in src/assets/primeng/components/fileupload/fileupload.js - About 6 hrs to fix

      Function __decorate has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
          var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
          if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
          else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
          return c > 3 && r && Object.defineProperty(target, key, r), r;
      Severity: Minor
      Found in src/assets/primeng/components/fileupload/fileupload.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function upload has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          FileUpload.prototype.upload = function () {
              var _this = this;
              if (this.customUpload) {
                  this.uploadHandler.emit({
                      files: this.files
      Severity: Minor
      Found in src/assets/primeng/components/fileupload/fileupload.js - About 1 hr to fix

        Similar blocks of code found in 77 locations. Consider refactoring.
        Open

        var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
            var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
            if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
            else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
            return c > 3 && r && Object.defineProperty(target, key, r), r;
        Severity: Major
        Found in src/assets/primeng/components/fileupload/fileupload.js and 76 other locations - About 1 day to fix
        src/assets/primeng/components/accordion/accordion.js on lines 2..7
        src/assets/primeng/components/autocomplete/autocomplete.js on lines 2..7
        src/assets/primeng/components/blockui/blockui.js on lines 2..7
        src/assets/primeng/components/breadcrumb/breadcrumb.js on lines 2..7
        src/assets/primeng/components/button/button.js on lines 2..7
        src/assets/primeng/components/calendar/calendar.js on lines 2..7
        src/assets/primeng/components/captcha/captcha.js on lines 2..7
        src/assets/primeng/components/carousel/carousel.js on lines 2..7
        src/assets/primeng/components/chart/chart.js on lines 2..7
        src/assets/primeng/components/checkbox/checkbox.js on lines 2..7
        src/assets/primeng/components/chips/chips.js on lines 2..7
        src/assets/primeng/components/codehighlighter/codehighlighter.js on lines 2..7
        src/assets/primeng/components/colorpicker/colorpicker.js on lines 2..7
        src/assets/primeng/components/common/confirmationservice.js on lines 2..7
        src/assets/primeng/components/common/messageservice.js on lines 2..7
        src/assets/primeng/components/common/shared.js on lines 2..7
        src/assets/primeng/components/common/treedragdropservice.js on lines 2..7
        src/assets/primeng/components/confirmdialog/confirmdialog.js on lines 2..7
        src/assets/primeng/components/contextmenu/contextmenu.js on lines 2..7
        src/assets/primeng/components/datagrid/datagrid.js on lines 2..7
        src/assets/primeng/components/datalist/datalist.js on lines 2..7
        src/assets/primeng/components/datascroller/datascroller.js on lines 2..7
        src/assets/primeng/components/datatable/datatable.js on lines 2..7
        src/assets/primeng/components/defer/defer.js on lines 2..7
        src/assets/primeng/components/dialog/dialog.js on lines 2..7
        src/assets/primeng/components/dom/domhandler.js on lines 2..7
        src/assets/primeng/components/dragdrop/dragdrop.js on lines 2..7
        src/assets/primeng/components/dropdown/dropdown.js on lines 2..7
        src/assets/primeng/components/editor/editor.js on lines 2..7
        src/assets/primeng/components/fieldset/fieldset.js on lines 2..7
        src/assets/primeng/components/galleria/galleria.js on lines 2..7
        src/assets/primeng/components/gmap/gmap.js on lines 2..7
        src/assets/primeng/components/growl/growl.js on lines 2..7
        src/assets/primeng/components/inplace/inplace.js on lines 2..7
        src/assets/primeng/components/inputmask/inputmask.js on lines 2..7
        src/assets/primeng/components/inputswitch/inputswitch.js on lines 2..7
        src/assets/primeng/components/inputtext/inputtext.js on lines 2..7
        src/assets/primeng/components/inputtextarea/inputtextarea.js on lines 2..7
        src/assets/primeng/components/lightbox/lightbox.js on lines 2..7
        src/assets/primeng/components/listbox/listbox.js on lines 2..7
        src/assets/primeng/components/megamenu/megamenu.js on lines 2..7
        src/assets/primeng/components/menu/menu.js on lines 2..7
        src/assets/primeng/components/menubar/menubar.js on lines 2..7
        src/assets/primeng/components/messages/messages.js on lines 2..7
        src/assets/primeng/components/multiselect/multiselect.js on lines 2..7
        src/assets/primeng/components/orderlist/orderlist.js on lines 2..7
        src/assets/primeng/components/organizationchart/organizationchart.js on lines 2..7
        src/assets/primeng/components/overlaypanel/overlaypanel.js on lines 2..7
        src/assets/primeng/components/paginator/paginator.js on lines 2..7
        src/assets/primeng/components/panel/panel.js on lines 2..7
        src/assets/primeng/components/panelmenu/panelmenu.js on lines 12..17
        src/assets/primeng/components/password/password.js on lines 2..7
        src/assets/primeng/components/picklist/picklist.js on lines 2..7
        src/assets/primeng/components/progressbar/progressbar.js on lines 2..7
        src/assets/primeng/components/radiobutton/radiobutton.js on lines 2..7
        src/assets/primeng/components/rating/rating.js on lines 2..7
        src/assets/primeng/components/schedule/schedule.js on lines 2..7
        src/assets/primeng/components/selectbutton/selectbutton.js on lines 2..7
        src/assets/primeng/components/sidebar/sidebar.js on lines 2..7
        src/assets/primeng/components/slidemenu/slidemenu.js on lines 2..7
        src/assets/primeng/components/slider/slider.js on lines 2..7
        src/assets/primeng/components/spinner/spinner.js on lines 2..7
        src/assets/primeng/components/splitbutton/splitbutton.js on lines 2..7
        src/assets/primeng/components/steps/steps.js on lines 2..7
        src/assets/primeng/components/tabmenu/tabmenu.js on lines 2..7
        src/assets/primeng/components/tabview/tabview.js on lines 2..7
        src/assets/primeng/components/terminal/terminal.js on lines 2..7
        src/assets/primeng/components/terminal/terminalservice.js on lines 2..7
        src/assets/primeng/components/tieredmenu/tieredmenu.js on lines 2..7
        src/assets/primeng/components/togglebutton/togglebutton.js on lines 2..7
        src/assets/primeng/components/toolbar/toolbar.js on lines 2..7
        src/assets/primeng/components/tooltip/tooltip.js on lines 2..7
        src/assets/primeng/components/tree/tree.js on lines 2..7
        src/assets/primeng/components/treetable/treetable.js on lines 2..7
        src/assets/primeng/components/tristatecheckbox/tristatecheckbox.js on lines 2..7
        src/assets/primeng/components/utils/objectutils.js on lines 2..7

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 237.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

        FileUpload = __decorate([
            core_1.Component({
                selector: 'p-fileUpload',
                template: "\n        <div [ngClass]=\"'ui-fileupload ui-widget'\" [ngStyle]=\"style\" [class]=\"styleClass\" *ngIf=\"mode === 'advanced'\">\n            <div class=\"ui-fileupload-buttonbar ui-widget-header ui-corner-top\">\n                <span class=\"ui-fileupload-choose\" [label]=\"chooseLabel\" icon=\"fa-plus\" pButton  [ngClass]=\"{'ui-state-focus': focus}\" [attr.disabled]=\"disabled\" > \n                    <input #advancedfileinput type=\"file\" (change)=\"onFileSelect($event)\" [multiple]=\"multiple\" [accept]=\"accept\" [disabled]=\"disabled\" (focus)=\"onFocus()\" (blur)=\"onBlur()\">\n                </span>\n\n                <button *ngIf=\"!auto&&showUploadButton\" type=\"button\" [label]=\"uploadLabel\" icon=\"fa-upload\" pButton (click)=\"upload()\" [disabled]=\"!hasFiles()\"></button>\n                <button *ngIf=\"!auto&&showCancelButton\" type=\"button\" [label]=\"cancelLabel\" icon=\"fa-close\" pButton (click)=\"clear()\" [disabled]=\"!hasFiles()\"></button>\n            \n                <p-templateLoader [template]=\"toolbarTemplate\"></p-templateLoader>\n            </div>\n            <div #content [ngClass]=\"{'ui-fileupload-content ui-widget-content ui-corner-bottom':true}\" \n                (dragenter)=\"onDragEnter($event)\" (dragleave)=\"onDragLeave($event)\" (drop)=\"onDrop($event)\">\n                <p-progressBar [value]=\"progress\" [showValue]=\"false\" *ngIf=\"hasFiles()\"></p-progressBar>\n                \n                <p-messages [value]=\"msgs\"></p-messages>\n                \n                <div class=\"ui-fileupload-files\" *ngIf=\"hasFiles()\">\n                    <div *ngIf=\"!fileTemplate\">\n                        <div class=\"ui-fileupload-row\" *ngFor=\"let file of files; let i = index;\">\n                            <div><img [src]=\"file.objectURL\" *ngIf=\"isImage(file)\" [width]=\"previewWidth\" /></div>\n                            <div>{{file.name}}</div>\n                            <div>{{formatSize(file.size)}}</div>\n                            <div><button type=\"button\" icon=\"fa-close\" pButton (click)=\"remove($event,i)\"></button></div>\n                        </div>\n                    </div>\n                    <div *ngIf=\"fileTemplate\">\n                        <ng-template ngFor [ngForOf]=\"files\" [ngForTemplate]=\"fileTemplate\"></ng-template>\n                    </div>\n                </div>\n                <p-templateLoader [template]=\"contentTemplate\"></p-templateLoader>\n            </div>\n        </div>\n        <span class=\"ui-button ui-fileupload-choose ui-widget ui-state-default ui-corner-all ui-button-text-icon-left\" *ngIf=\"mode === 'basic'\" \n        (mouseup)=\"onSimpleUploaderClick($event)\"\n        [ngClass]=\"{'ui-fileupload-choose-selected': hasFiles(),'ui-state-focus': focus}\">\n            <span class=\"ui-button-icon-left fa\" [ngClass]=\"{'fa-plus': !hasFiles()||auto, 'fa-upload': hasFiles()&&!auto}\"></span>\n            <span class=\"ui-button-text ui-clickable\">{{auto ? chooseLabel : hasFiles() ? files[0].name : chooseLabel}}</span>\n            <input #basicfileinput type=\"file\" [accept]=\"accept\" [multiple]=\"multiple\" [disabled]=\"disabled\"\n                (change)=\"onFileSelect($event)\" *ngIf=\"!hasFiles()\" (focus)=\"onFocus()\" (blur)=\"onBlur()\">\n        </span>\n    ",
                providers: [domhandler_1.DomHandler]
        Severity: Major
        Found in src/assets/primeng/components/fileupload/fileupload.js and 8 other locations - About 1 hr to fix
        src/assets/primeng/components/contextmenu/contextmenu.js on lines 228..235
        src/assets/primeng/components/datascroller/datascroller.js on lines 196..203
        src/assets/primeng/components/lightbox/lightbox.js on lines 189..196
        src/assets/primeng/components/megamenu/megamenu.js on lines 100..107
        src/assets/primeng/components/menubar/menubar.js on lines 100..107
        src/assets/primeng/components/slidemenu/slidemenu.js on lines 204..211
        src/assets/primeng/components/terminal/terminal.js on lines 86..93
        src/assets/primeng/components/tieredmenu/tieredmenu.js on lines 156..163

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 71 locations. Consider refactoring.
        Open

        var __metadata = (this && this.__metadata) || function (k, v) {
            if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
        };
        Severity: Major
        Found in src/assets/primeng/components/fileupload/fileupload.js and 70 other locations - About 1 hr to fix
        src/assets/primeng/components/accordion/accordion.js on lines 8..10
        src/assets/primeng/components/autocomplete/autocomplete.js on lines 8..10
        src/assets/primeng/components/blockui/blockui.js on lines 8..10
        src/assets/primeng/components/breadcrumb/breadcrumb.js on lines 8..10
        src/assets/primeng/components/button/button.js on lines 8..10
        src/assets/primeng/components/calendar/calendar.js on lines 8..10
        src/assets/primeng/components/captcha/captcha.js on lines 8..10
        src/assets/primeng/components/carousel/carousel.js on lines 8..10
        src/assets/primeng/components/chart/chart.js on lines 8..10
        src/assets/primeng/components/checkbox/checkbox.js on lines 8..10
        src/assets/primeng/components/chips/chips.js on lines 8..10
        src/assets/primeng/components/codehighlighter/codehighlighter.js on lines 8..10
        src/assets/primeng/components/colorpicker/colorpicker.js on lines 8..10
        src/assets/primeng/components/common/shared.js on lines 8..10
        src/assets/primeng/components/confirmdialog/confirmdialog.js on lines 8..10
        src/assets/primeng/components/contextmenu/contextmenu.js on lines 8..10
        src/assets/primeng/components/datagrid/datagrid.js on lines 8..10
        src/assets/primeng/components/datalist/datalist.js on lines 8..10
        src/assets/primeng/components/datascroller/datascroller.js on lines 8..10
        src/assets/primeng/components/datatable/datatable.js on lines 8..10
        src/assets/primeng/components/defer/defer.js on lines 8..10
        src/assets/primeng/components/dialog/dialog.js on lines 8..10
        src/assets/primeng/components/dragdrop/dragdrop.js on lines 8..10
        src/assets/primeng/components/dropdown/dropdown.js on lines 8..10
        src/assets/primeng/components/editor/editor.js on lines 8..10
        src/assets/primeng/components/fieldset/fieldset.js on lines 8..10
        src/assets/primeng/components/galleria/galleria.js on lines 8..10
        src/assets/primeng/components/gmap/gmap.js on lines 8..10
        src/assets/primeng/components/growl/growl.js on lines 8..10
        src/assets/primeng/components/inplace/inplace.js on lines 8..10
        src/assets/primeng/components/inputmask/inputmask.js on lines 8..10
        src/assets/primeng/components/inputswitch/inputswitch.js on lines 8..10
        src/assets/primeng/components/inputtext/inputtext.js on lines 8..10
        src/assets/primeng/components/inputtextarea/inputtextarea.js on lines 8..10
        src/assets/primeng/components/lightbox/lightbox.js on lines 8..10
        src/assets/primeng/components/listbox/listbox.js on lines 8..10
        src/assets/primeng/components/megamenu/megamenu.js on lines 8..10
        src/assets/primeng/components/menu/menu.js on lines 8..10
        src/assets/primeng/components/menubar/menubar.js on lines 8..10
        src/assets/primeng/components/messages/messages.js on lines 8..10
        src/assets/primeng/components/multiselect/multiselect.js on lines 8..10
        src/assets/primeng/components/orderlist/orderlist.js on lines 8..10
        src/assets/primeng/components/organizationchart/organizationchart.js on lines 8..10
        src/assets/primeng/components/overlaypanel/overlaypanel.js on lines 8..10
        src/assets/primeng/components/paginator/paginator.js on lines 8..10
        src/assets/primeng/components/panel/panel.js on lines 8..10
        src/assets/primeng/components/panelmenu/panelmenu.js on lines 18..20
        src/assets/primeng/components/password/password.js on lines 8..10
        src/assets/primeng/components/picklist/picklist.js on lines 8..10
        src/assets/primeng/components/progressbar/progressbar.js on lines 8..10
        src/assets/primeng/components/radiobutton/radiobutton.js on lines 8..10
        src/assets/primeng/components/rating/rating.js on lines 8..10
        src/assets/primeng/components/schedule/schedule.js on lines 8..10
        src/assets/primeng/components/selectbutton/selectbutton.js on lines 8..10
        src/assets/primeng/components/sidebar/sidebar.js on lines 8..10
        src/assets/primeng/components/slidemenu/slidemenu.js on lines 8..10
        src/assets/primeng/components/slider/slider.js on lines 8..10
        src/assets/primeng/components/spinner/spinner.js on lines 8..10
        src/assets/primeng/components/splitbutton/splitbutton.js on lines 8..10
        src/assets/primeng/components/steps/steps.js on lines 8..10
        src/assets/primeng/components/tabmenu/tabmenu.js on lines 8..10
        src/assets/primeng/components/tabview/tabview.js on lines 8..10
        src/assets/primeng/components/terminal/terminal.js on lines 8..10
        src/assets/primeng/components/tieredmenu/tieredmenu.js on lines 8..10
        src/assets/primeng/components/togglebutton/togglebutton.js on lines 8..10
        src/assets/primeng/components/toolbar/toolbar.js on lines 8..10
        src/assets/primeng/components/tooltip/tooltip.js on lines 8..10
        src/assets/primeng/components/tree/tree.js on lines 8..10
        src/assets/primeng/components/treetable/treetable.js on lines 8..10
        src/assets/primeng/components/tristatecheckbox/tristatecheckbox.js on lines 8..10

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status