Intellicode/eslint-plugin-react-native

View on GitHub
lib/util/Components.js

Summary

Maintainability
F
3 days
Test Coverage

Function componentRule has a Cognitive Complexity of 89 (exceeds 5 allowed). Consider refactoring.
Open

function componentRule(rule, context) {
  const sourceCode = context.getSourceCode();
  const components = new Components();

  // Utilities for component detection
Severity: Minor
Found in lib/util/Components.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function componentRule has 216 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function componentRule(rule, context) {
  const sourceCode = context.getSourceCode();
  const components = new Components();

  // Utilities for component detection
Severity: Major
Found in lib/util/Components.js - About 1 day to fix

    File Components.js has 277 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * @fileoverview Utility class and functions for React components detection
     * @author Yannick Croissant
     */
    
    
    Severity: Minor
    Found in lib/util/Components.js - About 2 hrs to fix

      Function getRelatedComponent has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getRelatedComponent: function (node) {
            let currentNode = node;
            let i;
            let j;
            let k;
      Severity: Major
      Found in lib/util/Components.js - About 2 hrs to fix

        Avoid too many return statements within this function.
        Open

              return components.get(currentNode);
        Severity: Major
        Found in lib/util/Components.js - About 30 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              ClassProperty: function () {
                const node = utils.getParentComponent();
                if (!node) {
                  return;
                }
          Severity: Minor
          Found in lib/util/Components.js and 2 other locations - About 35 mins to fix
          lib/util/Components.js on lines 341..347
          lib/util/Components.js on lines 349..355

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (currentNode.object && currentNode.object.type === 'Identifier') {
                    componentPath.push(currentNode.object.name);
                  }
          Severity: Minor
          Found in lib/util/Components.js and 1 other location - About 35 mins to fix
          lib/util/Components.js on lines 250..252

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (currentNode.property && currentNode.property.type === 'Identifier') {
                    componentPath.push(currentNode.property.name);
                  }
          Severity: Minor
          Found in lib/util/Components.js and 1 other location - About 35 mins to fix
          lib/util/Components.js on lines 253..255

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              FunctionExpression: function () {
                const node = utils.getParentComponent();
                if (!node) {
                  return;
                }
          Severity: Minor
          Found in lib/util/Components.js and 2 other locations - About 35 mins to fix
          lib/util/Components.js on lines 326..332
          lib/util/Components.js on lines 349..355

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              FunctionDeclaration: function () {
                const node = utils.getParentComponent();
                if (!node) {
                  return;
                }
          Severity: Minor
          Found in lib/util/Components.js and 2 other locations - About 35 mins to fix
          lib/util/Components.js on lines 326..332
          lib/util/Components.js on lines 341..347

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status