Sign upLogin

Irio/mymoip

View on GitHub
Star

Showing 7 of 7 total issues

Method to_xml has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    def to_xml(root = nil)
      raise InvalidPayer       if payer.invalid?
      raise InvalidPaymentSlip if payment_slip and payment_slip.invalid?
      raise InvalidInstruction if self.invalid?
      if invalid_commission = commissions.detect { |c| c.invalid? }
Severity: Minor
Found in lib/mymoip/instruction.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_xml has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def to_xml(root = nil)
      raise InvalidPaymentSlip if invalid?

      if root.nil?
        xml = ""
Severity: Minor
Found in lib/mymoip/payment_slip.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_xml has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def to_xml(root = nil)
      if root.nil?
        xml = ""
        root ||= Builder::XmlMarkup.new(target: xml)
      end
Severity: Minor
Found in lib/mymoip/payment_methods.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_xml has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def to_xml(root = nil)
      raise InvalidPayer       if payer.invalid?
      raise InvalidPaymentSlip if payment_slip and payment_slip.invalid?
      raise InvalidInstruction if self.invalid?
      if invalid_commission = commissions.detect { |c| c.invalid? }
Severity: Minor
Found in lib/mymoip/instruction.rb - About 1 hr to fix

    Method to_json has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def to_json(formatter = MyMoip::Formatter)
      raise InvalidCreditCard, 'No credit card provided.' if credit_card.nil?
      raise InvalidCreditCard                             if credit_card.invalid?

      json = {
    Severity: Minor
    Found in lib/mymoip/payments/credit_card_payment.rb - About 1 hr to fix

      Method to_xml has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def to_xml(root = nil)
      raise InvalidComission if invalid?

      if root.nil?
        xml  = ""
      Severity: Minor
      Found in lib/mymoip/commission.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method api_call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def api_call(params, opts = {})
      opts[:logger]   ||= MyMoip.logger
      opts[:username] ||= MyMoip.token
      opts[:password] ||= MyMoip.key
      Severity: Minor
      Found in lib/mymoip/request.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language