Jasig/WebproxyPortlet

View on GitHub

Showing 52 of 60 total issues

Avoid too many return statements within this method.
Open

                return false;

    Avoid too many return statements within this method.
    Open

                return false;

      Avoid too many return statements within this method.
      Open

              return true;

        Avoid too many return statements within this method.
        Open

                    return false;

          Avoid too many return statements within this method.
          Open

                          return false;

            Avoid too many return statements within this method.
            Open

                            return false;

              Avoid too many return statements within this method.
              Open

                          return false;

                Avoid too many return statements within this method.
                Open

                                return false;

                  Avoid too many return statements within this method.
                  Open

                              return false;

                    Method showContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @RenderMapping
                        public void showContent(final RenderRequest request, final RenderResponse response) {
                            log.debug("Entering render mapping");
                            IContentResponse proxyResponse = null;
                            try {

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method search has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @Override
                        public List<SearchResult> search(SearchRequest searchQuery,
                                EventRequest request, Document document) {
                            List<SearchResult> results = new ArrayList<SearchResult>();
                            final String[] whitelistRegexes = request.getPreferences().getValues("anchorWhitelistRegex", new String[] {});
                    Severity: Minor
                    Found in src/main/java/org/jasig/portlet/proxy/search/AnchorSearchStrategy.java - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method getAccessibleEntry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected GatewayEntry getAccessibleEntry(List<GatewayEntry> entries, PortletRequest request, String beanName) {
                            for (GatewayEntry entry : entries) {
                                if (entry.getName().equals(beanName)) {
                                    if (entry.entryIsAccessible(request)) {
                                        return entry;

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language