Showing 18 of 31 total issues
File Redis.php
has 303 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace Prometheus\Storage;
Method collectHistograms
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function collectHistograms()
{
$histograms = [];
foreach ($this->histograms as $histogram) {
$metaData = $histogram['meta'];
Method collectHistograms
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function collectHistograms()
{
$histograms = array();
foreach (new \APCUIterator('/^prom:histogram:.*:meta/') as $histogram) {
$metaData = json_decode($histogram['value'], true);
Function collectHistograms
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
private function collectHistograms()
{
$keys = $this->redis->sMembers(self::$prefix . Histogram::TYPE . self::PROMETHEUS_METRIC_KEYS_SUFFIX);
sort($keys);
$histograms = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method collectHistograms
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function collectHistograms()
{
$keys = $this->redis->sMembers(self::$prefix . Histogram::TYPE . self::PROMETHEUS_METRIC_KEYS_SUFFIX);
sort($keys);
$histograms = array();
Function collectHistograms
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
private function collectHistograms()
{
$histograms = array();
foreach (new \APCUIterator('/^prom:histogram:.*:meta/') as $histogram) {
$metaData = json_decode($histogram['value'], true);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function collectHistograms
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
private function collectHistograms()
{
$histograms = [];
foreach ($this->histograms as $histogram) {
$metaData = $histogram['meta'];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method updateHistogram
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function updateHistogram(array $data)
{
$this->openConnection();
$bucketToIncrease = '+Inf';
foreach ($data['buckets'] as $bucket) {
Method updateGauge
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function updateGauge(array $data)
{
$this->openConnection();
$metaData = $data;
unset($metaData['value']);
Function __construct
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function __construct(Adapter $adapter, $namespace, $name, $help, $labels = array(), $buckets = null)
{
parent::__construct($adapter, $namespace, $name, $help, $labels);
if (null === $buckets) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct(Adapter $adapter, $namespace, $name, $help, $labels = array(), $buckets = null)
Method registerHistogram
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function registerHistogram($namespace, $name, $help, $labels = array(), $buckets = null)
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct(Adapter $storageAdapter, $namespace, $name, $help, $labels = array())
Method getOrRegisterHistogram
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getOrRegisterHistogram($namespace, $name, $help, $labels = array(), $buckets = null)
Function updateHistogram
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function updateHistogram(array $data)
{
// Initialize the sum
$metaKey = $this->metaKey($data);
if (array_key_exists($metaKey, $this->histograms) === false) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function __construct
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function __construct(array $options = array())
{
// with php 5.3 we cannot initialize the options directly on the field definition
// so we initialize them here for now
if (!isset(self::$defaultOptions['host'])) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function updateHistogram
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function updateHistogram(array $data)
{
// Initialize the sum
$sumKey = $this->histogramBucketValueKey($data, 'sum');
$new = apcu_add($sumKey, $this->toInteger(0));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function updateGauge
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function updateGauge(array $data)
{
$valueKey = $this->valueKey($data);
if ($data['command'] == Adapter::COMMAND_SET) {
apcu_store($valueKey, $this->toInteger($data['value']));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"