Sign upLogin

Jimdo/prometheus_client_php

View on GitHub
Star

Showing 18 of 31 total issues

File Redis.php has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Prometheus\Storage;
Severity: Minor
Found in src/Prometheus/Storage/Redis.php - About 3 hrs to fix

    Method collectHistograms has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function collectHistograms()
    {
        $histograms = [];
        foreach ($this->histograms as $histogram) {
            $metaData = $histogram['meta'];
    Severity: Major
    Found in src/Prometheus/Storage/InMemory.php - About 2 hrs to fix

      Method collectHistograms has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function collectHistograms()
    {
        $histograms = array();
        foreach (new \APCUIterator('/^prom:histogram:.*:meta/') as $histogram) {
            $metaData = json_decode($histogram['value'], true);
      Severity: Major
      Found in src/Prometheus/Storage/APC.php - About 2 hrs to fix

        Function collectHistograms has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            private function collectHistograms()
    {
        $keys = $this->redis->sMembers(self::$prefix . Histogram::TYPE . self::PROMETHEUS_METRIC_KEYS_SUFFIX);
        sort($keys);
        $histograms = array();
        Severity: Minor
        Found in src/Prometheus/Storage/Redis.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method collectHistograms has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function collectHistograms()
    {
        $keys = $this->redis->sMembers(self::$prefix . Histogram::TYPE . self::PROMETHEUS_METRIC_KEYS_SUFFIX);
        sort($keys);
        $histograms = array();
        Severity: Major
        Found in src/Prometheus/Storage/Redis.php - About 2 hrs to fix

          Function collectHistograms has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private function collectHistograms()
    {
        $histograms = [];
        foreach ($this->histograms as $histogram) {
            $metaData = $histogram['meta'];
          Severity: Minor
          Found in src/Prometheus/Storage/InMemory.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function collectHistograms has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private function collectHistograms()
    {
        $histograms = array();
        foreach (new \APCUIterator('/^prom:histogram:.*:meta/') as $histogram) {
            $metaData = json_decode($histogram['value'], true);
          Severity: Minor
          Found in src/Prometheus/Storage/APC.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method updateHistogram has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function updateHistogram(array $data)
    {
        $this->openConnection();
        $bucketToIncrease = '+Inf';
        foreach ($data['buckets'] as $bucket) {
          Severity: Minor
          Found in src/Prometheus/Storage/Redis.php - About 1 hr to fix

            Method updateGauge has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function updateGauge(array $data)
    {
        $this->openConnection();
        $metaData = $data;
        unset($metaData['value']);
            Severity: Minor
            Found in src/Prometheus/Storage/Redis.php - About 1 hr to fix

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function __construct(Adapter $adapter, $namespace, $name, $help, $labels = array(), $buckets = null)
              Severity: Minor
              Found in src/Prometheus/Histogram.php - About 45 mins to fix

                Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function __construct(Adapter $adapter, $namespace, $name, $help, $labels = array(), $buckets = null)
    {
        parent::__construct($adapter, $namespace, $name, $help, $labels);

        if (null === $buckets) {
                Severity: Minor
                Found in src/Prometheus/Histogram.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct(Adapter $storageAdapter, $namespace, $name, $help, $labels = array())
                Severity: Minor
                Found in src/Prometheus/Collector.php - About 35 mins to fix

                  Method getOrRegisterHistogram has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function getOrRegisterHistogram($namespace, $name, $help, $labels = array(), $buckets = null)
                  Severity: Minor
                  Found in src/Prometheus/CollectorRegistry.php - About 35 mins to fix

                    Method registerHistogram has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function registerHistogram($namespace, $name, $help, $labels = array(), $buckets = null)
                    Severity: Minor
                    Found in src/Prometheus/CollectorRegistry.php - About 35 mins to fix

                      Function updateHistogram has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function updateHistogram(array $data)
    {
        // Initialize the sum
        $metaKey = $this->metaKey($data);
        if (array_key_exists($metaKey, $this->histograms) === false) {
                      Severity: Minor
                      Found in src/Prometheus/Storage/InMemory.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function __construct(array $options = array())
    {
        // with php 5.3 we cannot initialize the options directly on the field definition
        // so we initialize them here for now
        if (!isset(self::$defaultOptions['host'])) {
                      Severity: Minor
                      Found in src/Prometheus/Storage/Redis.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function updateGauge has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function updateGauge(array $data)
    {
        $valueKey = $this->valueKey($data);
        if ($data['command'] == Adapter::COMMAND_SET) {
            apcu_store($valueKey, $this->toInteger($data['value']));
                      Severity: Minor
                      Found in src/Prometheus/Storage/APC.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function updateHistogram has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function updateHistogram(array $data)
    {
        // Initialize the sum
        $sumKey = $this->histogramBucketValueKey($data, 'sum');
        $new = apcu_add($sumKey, $this->toInteger(0));
                      Severity: Minor
                      Found in src/Prometheus/Storage/APC.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language