Sign upLogin

JohnCashmore/node-fonts-used

View on GitHub
Star

Showing 5 of 5 total issues

Function parse has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

  function parse(input) {
    var state = states.VARIATION,
        buffer = '',
        result = {
          'font-family': []
Severity: Minor
Found in lib/parseFont.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function parse(input) {
    var state = states.VARIATION,
        buffer = '',
        result = {
          'font-family': []
Severity: Major
Found in lib/parseFont.js - About 2 hrs to fix

    Function findFonts has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.findFonts = function (strCSS) {
    var obj = css.parse(strCSS);
    var fonts = [];
    obj.stylesheet.rules.forEach(function (rule) {
        if(rule.declarations) {
    Severity: Minor
    Found in lib/fonts-used.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

            } else if (state === states.LINE_HEIGHT && c === ' ') {
        if (/^(\+|-)?([0-9]*\.)?[0-9]+(em|ex|ch|rem|vh|vw|vmin|vmax|px|mm|cm|in|pt|pc|%)?$/.test(buffer)) {
          result['line-height'] = buffer;
        }
        state = states.FONT_FAMILY;
      Severity: Major
      Found in lib/parseFont.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                if (/^((xx|x)-large|(xx|s)-small|small|large|medium)$/.test(buffer) ||
            /^(larg|small)er$/.test(buffer) ||
            /^(\+|-)?([0-9]*\.)?[0-9]+(em|ex|ch|rem|vh|vw|vmin|vmax|px|mm|cm|in|pt|pc|%)$/.test(buffer)) {
          state = c === '/' ? states.LINE_HEIGHT : states.FONT_FAMILY;
          result['font-size'] = buffer;
        Severity: Major
        Found in lib/parseFont.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language