Sign upLogin

JohnCoates/Slate

View on GitHub
Star

Showing 201 of 304 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    func testAtMostOperators() {
        buildSingle(attribute: .left, views: views) { $0.left -->-= $1 }
        buildSingle(attribute: .width, views: views) { $0.width -->-= $1.width }
        buildSingle(attribute: .height, views: views) { $0.height -->-= $1 }
        buildSingle(attribute: .width, view: views[0], constant: constants[0]) { $0.width -->-= $1 }
Severity: Major
Found in Tests/UI/Auto Layout/AutoLayoutOperatorTests.swift and 1 other location - About 4 hrs to fix
Tests/UI/Auto Layout/AutoLayoutOperatorTests.swift on lines 65..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 281.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    func testAtLeastOperators() {
        buildSingle(attribute: .left, views: views) { $0.left -->+= $1 }
        buildSingle(attribute: .width, views: views) { $0.width -->+= $1.width }
        buildSingle(attribute: .height, views: views) { $0.height -->+= $1 }
        buildSingle(attribute: .width, view: views[0], constant: constants[0]) { $0.width -->+= $1 }
Severity: Major
Found in Tests/UI/Auto Layout/AutoLayoutOperatorTests.swift and 1 other location - About 4 hrs to fix
Tests/UI/Auto Layout/AutoLayoutOperatorTests.swift on lines 79..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 281.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation

@objc(DBFrameRate)
class DBFrameRate: NSObject, NSCoding {
    private var rate: Int?
Severity: Major
Found in Source/UI/Kits/Models/Subgroups/Photo Settings/Attributes/Data Models/DBFrameRate.swift and 1 other location - About 4 hrs to fix
Source/UI/Kits/Models/Subgroups/Photo Settings/Attributes/Data Models/DBBurstSpeed.swift on lines 7..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 276.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation

@objc(DBBurstSpeed)
class DBBurstSpeed: NSObject, NSCoding {
    private var speed: Int?
Severity: Major
Found in Source/UI/Kits/Models/Subgroups/Photo Settings/Attributes/Data Models/DBBurstSpeed.swift and 1 other location - About 4 hrs to fix
Source/UI/Kits/Models/Subgroups/Photo Settings/Attributes/Data Models/DBFrameRate.swift on lines 7..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 276.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @objc func menuDragged(gesture: UIPanGestureRecognizer) {
        if gesture.state == .began || gesture.state == .ended || gesture.state == .cancelled {
            menuLastTranslationY = nil
        }
        guard gesture.state == .changed else {
Severity: Major
Found in Source/UI/Capture/View Controllers/Extensions/BaseCaptureViewController+ComponentMenu.swift and 1 other location - About 2 hrs to fix
Source/UI/Capture/View Controllers/Extensions/BaseCaptureViewController+ComponentEditing.swift on lines 35..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @objc func editBarDragged(gesture: UIPanGestureRecognizer) {
        if gesture.state == .began || gesture.state == .ended || gesture.state == .cancelled {
            editBarLastTranslationY = nil
        }
        guard gesture.state == .changed else {
Severity: Major
Found in Source/UI/Capture/View Controllers/Extensions/BaseCaptureViewController+ComponentEditing.swift and 1 other location - About 2 hrs to fix
Source/UI/Capture/View Controllers/Extensions/BaseCaptureViewController+ComponentMenu.swift on lines 37..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    var customSection: TableSection {
        var rows = [TableRow]()
        let footer = """
                    The higher that you set the frame rate,
                    the more resolution will need to be reduced to keep up.
Severity: Major
Found in Source/UI/Kits/Edit/Subgroups/Photo Settings/Frame Rate/FrameRateSettingsViewController.swift and 1 other location - About 2 hrs to fix
Source/UI/Kits/Edit/Subgroups/Photo Settings/Burst Speed/BurstSpeedSettingsViewController.swift on lines 83..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    var customSection: TableSection {
        var rows = [TableRow]()
        let footer = """
                    The higher that you set the Burst Speed,
                    the more Resolution will need to be reduced to keep up.
Severity: Major
Found in Source/UI/Kits/Edit/Subgroups/Photo Settings/Burst Speed/BurstSpeedSettingsViewController.swift and 1 other location - About 2 hrs to fix
Source/UI/Kits/Edit/Subgroups/Photo Settings/Frame Rate/FrameRateSettingsViewController.swift on lines 84..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    func transformed(path: CGPath, forFrame frame: CGRect) -> CGPath {
        let scale = frame.size.width / CGFloat(canvas.width)
        let translationFactor = CGFloat(canvas.width) / frame.size.width
        
        var affineTransform = CGAffineTransform.init(scaleX: scale, y: scale)
Severity: Major
Found in Source/UI/Assets/Vector Images/Views/PathsImageButton.swift and 1 other location - About 2 hrs to fix
Source/UI/Assets/Vector Images/Views/InverseMaskImageButton.swift on lines 95..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    func transformed(path: CGPath, forFrame frame: CGRect) -> CGPath {
        let scale = frame.size.width / CGFloat(canvas.width)
        let translationFactor = CGFloat(canvas.width) / frame.size.width
        
        var affineTransform = CGAffineTransform.init(scaleX: scale, y: scale)
Severity: Major
Found in Source/UI/Assets/Vector Images/Views/InverseMaskImageButton.swift and 1 other location - About 2 hrs to fix
Source/UI/Assets/Vector Images/Views/PathsImageButton.swift on lines 92..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import CoreData

@objc(PhotoSettingsAddBurstSpeed)
class PhotoSettingsAddBurstSpeed: EntityMigrationPolicy {
Severity: Major
Found in Source/Database/Data Model/Migrating/Entity Policies/PhotoSettingsAddBurstSpeed.swift and 1 other location - About 2 hrs to fix
Source/Database/Data Model/Migrating/Entity Policies/PhotoSettingsAddFrameRate.swift on lines 7..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 151.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import CoreData

@objc(PhotoSettingsAddFrameRate)
class PhotoSettingsAddFrameRate: EntityMigrationPolicy {
Severity: Major
Found in Source/Database/Data Model/Migrating/Entity Policies/PhotoSettingsAddFrameRate.swift and 1 other location - About 2 hrs to fix
Source/Database/Data Model/Migrating/Entity Policies/PhotoSettingsAddBurstSpeed.swift on lines 7..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 151.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private func burstSpeedRows() -> [TableRow] {
        var rows: [TableRow] = []
        rows.append(TypedLinkRow(title: "Selected", detail: photoSettings.burstSpeed,
                                 identifier: .burstSpeed, onSelect: onSelect))
        let constraintsMaybe = constraintResolver.burstSpeedConstraints
Severity: Major
Found in Source/UI/Kits/Edit/Subgroups/Photo Settings/KitPhotoSettingsViewController.swift and 1 other location - About 2 hrs to fix
Source/UI/Kits/Edit/Subgroups/Photo Settings/KitPhotoSettingsViewController.swift on lines 90..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private func frameRateRows() -> [TableRow] {
        var rows: [TableRow] = []
        rows.append(TypedLinkRow(title: "Selected", detail: photoSettings.frameRate,
                                 identifier: .frameRate, onSelect: onSelect))
Severity: Major
Found in Source/UI/Kits/Edit/Subgroups/Photo Settings/KitPhotoSettingsViewController.swift and 1 other location - About 2 hrs to fix
Source/UI/Kits/Edit/Subgroups/Photo Settings/KitPhotoSettingsViewController.swift on lines 110..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        switch first {
        case .initWith(let rect):
            path = UIBezierPath(rect: rect.cgRect)
        case .initWith2(let rect, let cornerRadius):
            path = UIBezierPath(roundedRect: rect.cgRect, cornerRadius: CGFloat(cornerRadius))
Severity: Major
Found in Source/UI/Assets/Vector Images/Models/Drawing/VectorImageCanvasIcon.swift and 1 other location - About 1 hr to fix
Source/UI/Assets/Vector Images/Views/InverseMaskImageButton.swift on lines 137..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        switch first {
        case .initWith(let rect):
            path = UIBezierPath(rect: rect.cgRect)
        case .initWith2(let rect, let cornerRadius):
            path = UIBezierPath(roundedRect: rect.cgRect, cornerRadius: CGFloat(cornerRadius))
Severity: Major
Found in Source/UI/Assets/Vector Images/Views/InverseMaskImageButton.swift and 1 other location - About 1 hr to fix
Source/UI/Assets/Vector Images/Models/Drawing/VectorImageCanvasIcon.swift on lines 82..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    func setUpIconProxy() {
        iconProxy.isHidden = true
        contentView.addSubview(iconProxy)
        
        let heightRatio = CGFloat(canvas.height) / CGFloat(canvas.width)
Severity: Major
Found in Source/UI/Assets/Vector Images/Views/InverseMaskImageButton.swift and 1 other location - About 1 hr to fix
Source/UI/Assets/Vector Images/Views/PathsImageButton.swift on lines 68..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    func setUpIconProxy() {
        iconProxy.isHidden = true
        contentView.addSubview(iconProxy)
        
        let heightRatio = CGFloat(canvas.height) / CGFloat(canvas.width)
Severity: Major
Found in Source/UI/Assets/Vector Images/Views/PathsImageButton.swift and 1 other location - About 1 hr to fix
Source/UI/Assets/Vector Images/Views/InverseMaskImageButton.swift on lines 79..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    func updateVertices(withViewSize viewSize: CGSize) {
        guard let inputSize = cameraController.inputSize else {
            print("Couldn't get camera input size!")
            return
        }
Severity: Major
Found in Source/UI/Capture/Metal/Renderer/Extensions/Renderer+Buffers.swift and 1 other location - About 1 hr to fix
Source/UI/Capture/Metal/Renderer/Extensions/Renderer+Buffers.swift on lines 97..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    func updateTextureCoordinates(withViewSize viewSize: CGSize) {
        guard let inputSize = cameraController.inputSize else {
            print("Couldn't get camera input size!")
            return
        }
Severity: Major
Found in Source/UI/Capture/Metal/Renderer/Extensions/Renderer+Buffers.swift and 1 other location - About 1 hr to fix
Source/UI/Capture/Metal/Renderer/Extensions/Renderer+Buffers.swift on lines 80..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language