Sign upLogin

JohnMunsch/ClearAndDraw

View on GitHub
Star
app/scripts/data.service.js

Summary

Maintainability
C
1 day
Test Coverage

Function filteredCards has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      this.filteredCards = function (cardList, team) {
        var setsList = _.compact(this.sets);
        var affiliationsList = _.compact(this.affiliations);
        var costsList = _.compact(_.map(this.costs, function (cost) { return parseInt(cost); }));
        var typesList = _.compact(this.types);
Severity: Minor
Found in app/scripts/data.service.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                  return false;
    Severity: Major
    Found in app/scripts/data.service.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                    return false;
      Severity: Major
      Found in app/scripts/data.service.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return true;
        Severity: Major
        Found in app/scripts/data.service.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                        return false;
          Severity: Major
          Found in app/scripts/data.service.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                          return false;
            Severity: Major
            Found in app/scripts/data.service.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    this.addDieToSelected = function (cardList, team) {
        // Get a list of all the unique dice represented by the selected cards. Find them within the team (or add
        // records if needed) and increment the count.
        _.each(_.uniq(_.pluck(selectedCards(cardList), 'dieId')), function (dieId) {
          dataSvc.addDieToTeam(dieId, team);
              Severity: Major
              Found in app/scripts/data.service.js and 1 other location - About 1 hr to fix
              app/scripts/data.service.js on lines 95..101

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    this.removeDieFromSelected = function (cardList, team) {
        // Get a list of all the unique dice represented by the selected cards. Find them within the team (or add
        // records if needed) and decrement the count.
        _.each(_.uniq(_.pluck(selectedCards(cardList), 'dieId')), function (dieId) {
          dataSvc.removeDieFromTeam(dieId, team);
              Severity: Major
              Found in app/scripts/data.service.js and 1 other location - About 1 hr to fix
              app/scripts/data.service.js on lines 87..93

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    this.removeCardFromSelected = function (cardList, team) {
        _.each(selectedCards(cardList), function (card) {
          dataSvc.removeCardFromTeam(card.id, card.setAbbr, team);
        });
      };
              Severity: Major
              Found in app/scripts/data.service.js and 1 other location - About 1 hr to fix
              app/scripts/data.service.js on lines 75..79

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    this.addCardToSelected = function (cardList, team) {
        _.each(selectedCards(cardList), function (card) {
          dataSvc.addCardToTeam(card.id, card.setAbbr, team);
        });
      };
              Severity: Major
              Found in app/scripts/data.service.js and 1 other location - About 1 hr to fix
              app/scripts/data.service.js on lines 81..85

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    this.selectAll = function (cardList) {
        _.each(cardList, function (card) {
          card.selected = true;
        });
      };
              Severity: Minor
              Found in app/scripts/data.service.js and 1 other location - About 30 mins to fix
              app/scripts/data.service.js on lines 63..67

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    this.selectNone = function (cardList) {
        _.each(cardList, function (card) {
          card.selected = false;
        });
      };
              Severity: Minor
              Found in app/scripts/data.service.js and 1 other location - About 30 mins to fix
              app/scripts/data.service.js on lines 57..61

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status